Skip to content

Add no-callback-literal rule#179

Merged
mysticatea merged 2 commits intomysticatea:masterfrom
feross:no-callback-literal
Aug 29, 2019
Merged

Add no-callback-literal rule#179
mysticatea merged 2 commits intomysticatea:masterfrom
feross:no-callback-literal

Conversation

@feross
Copy link
Copy Markdown
Contributor

@feross feross commented Aug 14, 2019

Fixes: #178

@mysticatea
Copy link
Copy Markdown
Owner

Thank you for your contribution!

Code looks good to me. Would you add docs/rules/no-callback-literal.md?

@feross
Copy link
Copy Markdown
Contributor Author

feross commented Aug 18, 2019

@mysticatea I just added a documentation file as you requested.

@mysticatea
Copy link
Copy Markdown
Owner

I'm sorry that I have lost track on this. LGTM, thank you!

@mysticatea mysticatea merged commit c1d5dbf into mysticatea:master Aug 29, 2019
@feross
Copy link
Copy Markdown
Contributor Author

feross commented Sep 4, 2019

Thank you @mysticatea!

@aleen42
Copy link
Copy Markdown

aleen42 commented Sep 21, 2020

Holy crap rule!! I don't know why I cannot callback literal like the state (boolean): cb(0) or cb(false) ?

brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt no-callback-literal rule

3 participants