Skip to content

Chore: support the new rule meta.type property (fixes #143)#145

Merged
mysticatea merged 1 commit intomysticatea:masterfrom
eslint-community:issue143
Dec 8, 2018
Merged

Chore: support the new rule meta.type property (fixes #143)#145
mysticatea merged 1 commit intomysticatea:masterfrom
eslint-community:issue143

Conversation

@aladdin-add
Copy link
Copy Markdown
Contributor

@aladdin-add aladdin-add commented Dec 4, 2018

thoughts on the types?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2018

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          64       64           
  Lines        1123     1123           
=======================================
  Hits         1103     1103           
  Misses         20       20
Impacted Files Coverage Δ
lib/rules/no-unpublished-bin.js 92.85% <ø> (ø) ⬆️
lib/rules/no-missing-require.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/url-search-params.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/console.js 100% <ø> (ø) ⬆️
lib/rules/shebang.js 97.56% <ø> (ø) ⬆️
lib/rules/prefer-global/buffer.js 100% <ø> (ø) ⬆️
lib/rules/no-unsupported-features/node-builtins.js 100% <ø> (ø) ⬆️
lib/rules/no-unpublished-import.js 100% <ø> (ø) ⬆️
lib/rules/no-deprecated-api.js 100% <ø> (ø) ⬆️
lib/rules/prefer-global/text-decoder.js 100% <ø> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932836b...43476c6. Read the comment docs.

Copy link
Copy Markdown
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 153ab03 into mysticatea:master Dec 8, 2018
@aladdin-add aladdin-add deleted the issue143 branch December 9, 2018 07:55
brettz9 pushed a commit to brettz9/eslint-plugin-node that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants