Repository navigation
Commit 0ac21e8
fix(telemetry): remove redundant captureException calls that double-count errors
Issue Zoo-Code-Org#513 identified captureException sites where the same error is
captured again downstream or where a named telemetry event already
carries the signal:
- Task.ts: captureException(new ConsecutiveMistakeError(...)) fired
right after captureConsecutiveMistakeError(), routing a deliberate
control-flow limit into error tracking as a duplicate.
- presentAssistantMessage.ts: same redundant pairing for the
tool_repetition guard.
- openai-native.ts: handleStreamResponse captured stream-processing
failures and rethrew, after which createMessage's catch captured the
same failure again.
The openrouter handleStreamingError capture was left in place: in
current code its rethrown error is not captured anywhere downstream
(createMessage has no enclosing catch for the stream loop and
completePrompt invokes it outside its try/catch), so removing it would
drop the only capture for mid-stream OpenRouter errors.1 parent fafad20 commit 0ac21e8
3 files changed
Lines changed: 5 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1129 | 1129 | | |
1130 | 1130 | | |
1131 | 1131 | | |
1132 | | - | |
1133 | | - | |
1134 | | - | |
1135 | | - | |
| 1132 | + | |
| 1133 | + | |
1136 | 1134 | | |
1137 | 1135 | | |
1138 | 1136 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
838 | | - | |
| 838 | + | |
839 | 839 | | |
840 | | - | |
841 | | - | |
842 | | - | |
843 | | - | |
844 | | - | |
845 | | - | |
846 | | - | |
847 | | - | |
848 | | - | |
849 | | - | |
850 | | - | |
851 | 840 | | |
852 | 841 | | |
853 | 842 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
| |||
3782 | 3781 | | |
3783 | 3782 | | |
3784 | 3783 | | |
3785 | | - | |
| 3784 | + | |
3786 | 3785 | | |
3787 | 3786 | | |
3788 | 3787 | | |
3789 | | - | |
3790 | | - | |
3791 | | - | |
3792 | | - | |
3793 | | - | |
3794 | | - | |
3795 | | - | |
3796 | | - | |
3797 | | - | |
3798 | | - | |
3799 | | - | |
3800 | 3788 | | |
3801 | 3789 | | |
3802 | 3790 | | |
| |||
0 commit comments