Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: myitcv/gopherjs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: upgrade_to_circle_ci_2
Choose a base ref
...
head repository: myitcv/gopherjs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: getters
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 6 files changed
  • 1 contributor

Commits on Jul 7, 2018

  1. js: add MakeFullWrapper to expose exported methods and struct fields. 

    Currently the documentation for js.MakeWrapper is:

> "MakeWrapper creates a JavaScript object which has wrappers for the
exported methods of i. Use explicit getter and setter methods to expose
struct fields to JavaScript."

Where the value a struct value (or more
interestingly a pointer to a struct value) we can actually auto-generate
getters and setters for exported fields in the JavaScript world, rather
than requiring explicit getters and setters to be defined on the Go
side.

We do this via a new MakeFullWrapper method.
    @myitcv
    myitcv committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    90371be View commit details
    Browse the repository at this point in the history
Loading