This repository was archived by the owner on Mar 23, 2021. It is now read-only.
Strip out an directory-based replacements from main pkg's module#78
Merged
Strip out an directory-based replacements from main pkg's module#78
Conversation
myitcv
force-pushed
the
drop_non_version_replace_directives
branch
4 times, most recently
from
bdf8333 to
42f704b
Compare
myitcv
force-pushed
the
drop_non_version_replace_directives
branch
from
42f704b to
87fa240
Compare
rogpeppe
approved these changes
Jul 29, 2019
Collaborator
rogpeppe
left a comment
rogpeppe
left a comment
There was a problem hiding this comment.
LGTM modulo one frivolous and one slightly less frivolous suggestion. Thanks!
testdata/mod/github.com_gobin-testrepos_simple-main-directory-replace_v1.0.0.txt
Outdated
Show resolved
Hide resolved
Per much previous discussion, we do apply replace directives in the main package's module. But for directory replacements this is not guaranteed to make sense. Indeed it almost certainly doesn't make sense most of the time. Therefore, strip out these replace directives, leaving behind the versioned, non-directory replaces.
myitcv
force-pushed
the
drop_non_version_replace_directives
branch
from
87fa240 to
4102a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per much previous discussion, we do apply replace directives in the main
package's module. But for directory replacements this is not guaranteed
to make sense. Indeed it almost certainly doesn't make sense most of the
time. Therefore, strip out these replace directives, leaving behind the
versioned, non-directory replaces.