Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: myitcv/gobin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.4
Choose a base ref
...
head repository: myitcv/gobin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.5
Choose a head ref
  • 6 commits
  • 234 files changed
  • 1 contributor

Commits on Nov 21, 2018

  1. main: ensure replace directives are applied for non-'-m' installs. (#48)

    We were previously, erroneously, not applying replace directives from
    the main package's module's go.mod file for non-'-m' installs. When
    calling gobin with -m, it is expected that such replace directives are
    not applied. But without -m, we effectively treat the main package's
    module as the main module (except that we actually treat it as a
    dependency, in order to capture the version information in the resulting
    binary).
    
    This commit fixes that discrepancy, and locks it in with a two tests,
    that compare the presence or otherwise of the replace directive between
    the non-'-m' and -m modes.
    myitcv authored Nov 21, 2018
    Configuration menu
    Copy the full SHA
    eef4e18 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. ci: add OSes to CI (#49)

    Adapt implementation and tests to cover Mac and Windows.
    myitcv authored Dec 3, 2018
    Configuration menu
    Copy the full SHA
    ec46cee View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. main: address feedback from #49 (#52)

    Addressing feedback from #49 that accidentally arrived after I merged.
    myitcv authored Dec 7, 2018
    Configuration menu
    Copy the full SHA
    b1b2f68 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. ci: add Go1.12beta to the build matrix (#56)

    As part of that, fix test where behaviour of go command has changed
    between 1.11 and 1.12 series.
    
    This also requires that we upgrade our dependency on
    github.com/rogpeppe/go-internal to take advantage of go version
    conditions.
    myitcv authored Jan 15, 2019
    Configuration menu
    Copy the full SHA
    69a9b82 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    86655cd View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. deps: temporarily remove requirement on myitcv.io (#58)

    Because of golang/go#29773, circular module
    requirements create a problem with Go 1.11 and 1.12beta2 (at least).
    
    The fix for this is scheduled for Go 1.13, but we need to add a
    dependency from myitcv.io -> github.com/myitcv/gobin now.
    
    Given that the dependency on myitcv.io is only a development-time tool
    dependency, the easiest thing to do for now is to drop that requirement,
    thereby breaking the cycle.
    myitcv authored Jan 25, 2019
    Configuration menu
    Copy the full SHA
    4cdfd9a View commit details
    Browse the repository at this point in the history
Loading