Repository navigation
docs: point AGENTS.md at files that exist - #390
Merged
Merged
Conversation
Three paths in AGENTS.md no longer resolve, and each is referenced three times, including in the Key Files Reference that an agent reads as the map of the tree: - `src/grammar.ts` — gone, and `src/` holds no grammar helpers at all (nothing there mentions GBNF, SchemaConverter or JSON-schema conversion) - `ios/RNLlamaJSI.mm` — gone; the iOS install path is entirely in `ios/RNLlama.mm`, which imports `../cpp/jsi/RNLlamaJSI.h` and calls `rnllama_jsi::installJSIBindings` - `android/.../RNLlamaModuleShared.java` — gone; the TurboModule entry point is `RNLlamaModule.java`, alongside `RNLlama.java` (which is indeed the native loader and HTP extractor the doc describes) Every other path the file names resolves, so this only corrects the three. Markdown only, no code touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three paths in
AGENTS.mdno longer resolve. Each is referenced three times, including in the Key Files Reference section that an agent reads as the map of the tree, so following them leads to files that are not there.src/grammar.tssrc/holds no grammar helpers at all — nothing under it mentions GBNF,SchemaConverter, or JSON-schema conversion.ios/RNLlamaJSI.mmios/RNLlama.mm, which imports../cpp/jsi/RNLlamaJSI.hand callsrnllama_jsi::installJSIBindings.android/src/main/java/com/rnllama/RNLlamaModuleShared.javaRNLlamaModule.java(extends NativeRNLlamaSpec), next toRNLlama.java— which is indeed the native loader and HTP extractor the doc describes.How I checked
I pulled every backticked path out of
AGENTS.mdand tested whether it resolves, rather than eyeballing it:Everything else the file names is accurate, so this only corrects those three — no rewording, no restructuring.
One caveat on my own method, since it nearly put wrong claims in here: a first pass reported 16 unresolved paths, but most of those were bare filenames like
rn-llama.cppandJSICompletion.hthat I was testing against the repo root when they live undercpp/andcpp/jsi/. Re-run correctly, only the three full paths above are genuinely stale.Scope
Markdown only — no code, no config.
npm run lintandnpm testcover neither this file nor anything it touches.