Conversation
Contributor
Author
|
Sorry, I have no idea what the CI error means (never worked with go outside this project). Can you give me a hand, please? |
Owner
|
Hey. Thanks for the contribution! I think this is because of maligned linter we use: Line 17 in b82bb35 Here is a good read which explain why it complains: https://medium.com/@sebassegros/golang-dealing-with-maligned-structs-9b77bacf4b97 Feel free to disable it if no luck, I'll take a look later. |
this is attempt to fix maligned lint error
Contributor
Author
|
@mxpv Any chance we can get an official release (and docker image) with this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #188
According to https://support.google.com/podcast-publishers/answer/10315648?hl=en&ref_topic=9476061,
<itunes:block>also prevents feed from being added to Google's aggregator, so<googleplay:block>is not neeeded.