fixup: Dockerfile: reinstate location of config.toml#271
Conversation
|
Alternatively, |
|
|
|
It does not need to be changed, the binary's location does not affect working directory (from what config.toml is taken from). I tried to test with:
p.c7.ee:
# image: mxpv/podsync:v2.4.1
# build: github.com/jtagcat/podsync#patch-1
build: podsync/ # git checked out at host $PWD/podsync
volumes:
- /barfoo:/app/data:rw
- /foobar/config.toml:/app/config.toml:roit worked (though comments in Dockerfile need to be on newline) Now, I have no idea how you get the binary in to the Dockerfile, |
|
anyw, ready to merge, tested |
|
Can you do (original version):
|
`config.toml` uses relative path, from the current directory, `$PWD` by default is `/`. commit f337f6c removed `WORKDIR /app`, and `/config.toml` was used instead of `/app/config.toml`. The change was breaking, unexpected and undocumented. As users already mount `/app/config.toml`, revert to using it. Revert 16315c0 (what was workaround for breaking change, though there is no need to break anything here) Closes #270 + requested: podsync located again at /app/podsync, instead of /podsync
|
As requested. |
|
Thanks |
readd
WORKDIR /appconfig.tomluses relative path, from the current directory,$PWDby default is/.commit f337f6c
removed
WORKDIR /app, and/config.tomlwas used instead of/app/config.toml.The change was breaking, unexpected and undocumented.
As users already mount
/app/config.toml, revert to using it.Closes #270