Merged
Conversation
Contributor
|
I think this should be made optional in case there is an alternative update mechanism. It may be hard to believe but not everyone uses docker these days :) |
Contributor
Author
|
@dop251 yep. you right. at now i think selfupdate and any another version management must be outside application logic. for self i use that bash script in cron |
Contributor
Author
|
i revert code, but has left changes in dockerfile |
mxpv
added a commit
that referenced
this pull request
Apr 19, 2020
Owner
|
I've added optional flag to enable youtube-dl self updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the right way we need make update by cron with lock and stop downloader goroutines.
I can't do it at the moment, but i think we can call selfupdate on start.
Until selfupdate by timer not implemented we can fix it by stop and start again 🤷♂️