fix(file): fallback image upload to local storage when S3 is disabled

Innei · Innei · commit 32ce77320061 · 2026-03-27T21:50:24.000+08:00
diff --git a/apps/core/src/modules/file/file.controller.ts b/apps/core/src/modules/file/file.controller.ts
@@ -162,11 +162,14 @@ export class FileController {
 
     // 获取文件上传配置
     const uploadConfig = await this.configsService.get('fileUploadOptions')
+    const imageStorageConfig =
+      type === 'image'
+        ? await this.configsService.get('imageStorageOptions')
+        : null
 
-    if (type === 'image') {
-      const config = await this.configsService.get('imageStorageOptions')
+    if (type === 'image' && imageStorageConfig?.enable) {
+      const config = imageStorageConfig
       if (
-        !config.enable ||
         !config.endpoint ||
         !config.secretId ||
         !config.secretKey ||
@@ -230,7 +233,14 @@ export class FileController {
       return { url: s3Url, name: filename }
     }
 
-    const file = await this.uploadService.getAndValidMultipartField(req)
+    const file = await this.uploadService.getAndValidMultipartField(
+      req,
+      type === 'image'
+        ? {
+            maxFileSize: 20 * 1024 * 1024,
+          }
+        : undefined,
+    )
 
     // 生成文件名（可能包含子路径）
     const rawFilename = generateFilename(uploadConfig, {
@@ -257,6 +267,12 @@ export class FileController {
 
     await this.service.writeFile(type, relativePath, file.file)
     const fileUrl = await this.service.resolveFileUrl(type, relativePath)
+    if (type === 'image') {
+      await this.fileReferenceService.createPendingReference(
+        fileUrl,
+        relativePath,
+      )
+    }
 
     return { url: fileUrl, name: path.basename(relativePath) }
   }
diff --git a/apps/core/test/src/modules/file/file.controller.spec.ts b/apps/core/test/src/modules/file/file.controller.spec.ts
@@ -0,0 +1,103 @@
+import { Readable } from 'node:stream'
+
+import { describe, expect, it, vi } from 'vitest'
+
+import { ErrorCodeEnum } from '~/constants/error-code.constant'
+import { FileController } from '~/modules/file/file.controller'
+
+describe('FileController', () => {
+  it('falls back to local storage for image uploads when S3 is disabled', async () => {
+    const writeFile = vi.fn().mockResolvedValue(undefined)
+    const resolveFileUrl = vi
+      .fn()
+      .mockResolvedValue('http://example.com/objects/image/nested/origin.png')
+    const getAndValidMultipartField = vi.fn().mockResolvedValue({
+      filename: 'origin.png',
+      file: Readable.from(['image-bytes']),
+    })
+    const createPendingReference = vi.fn().mockResolvedValue(undefined)
+    const get = vi.fn().mockImplementation((key: string) => {
+      if (key === 'fileUploadOptions') {
+        return Promise.resolve({
+          enableCustomNaming: true,
+          filenameTemplate: '{name}{ext}',
+          pathTemplate: '{type}/nested',
+        })
+      }
+      if (key === 'imageStorageOptions') {
+        return Promise.resolve({
+          enable: false,
+        })
+      }
+      return Promise.reject(new Error(`Unexpected config key: ${key}`))
+    })
+
+    const controller = new FileController(
+      { writeFile, resolveFileUrl } as any,
+      { getAndValidMultipartField } as any,
+      { createPendingReference } as any,
+      { get } as any,
+    )
+
+    const result = await controller.upload({ type: 'image' } as any, {} as any)
+
+    expect(getAndValidMultipartField).toHaveBeenCalledWith(
+      {},
+      expect.objectContaining({ maxFileSize: 20 * 1024 * 1024 }),
+    )
+    expect(writeFile).toHaveBeenCalledWith(
+      'image',
+      'nested/origin.png',
+      expect.any(Readable),
+    )
+    expect(resolveFileUrl).toHaveBeenCalledWith('image', 'nested/origin.png')
+    expect(createPendingReference).toHaveBeenCalledWith(
+      'http://example.com/objects/image/nested/origin.png',
+      'nested/origin.png',
+    )
+    expect(result).toEqual({
+      url: 'http://example.com/objects/image/nested/origin.png',
+      name: 'origin.png',
+    })
+  })
+
+  it('throws when S3 image storage is enabled but incomplete', async () => {
+    const writeFile = vi.fn()
+    const getAndValidMultipartField = vi.fn()
+    const createPendingReference = vi.fn()
+    const get = vi.fn().mockImplementation((key: string) => {
+      if (key === 'fileUploadOptions') {
+        return Promise.resolve({
+          enableCustomNaming: false,
+        })
+      }
+      if (key === 'imageStorageOptions') {
+        return Promise.resolve({
+          enable: true,
+          endpoint: '',
+          secretId: '',
+          secretKey: '',
+          bucket: '',
+        })
+      }
+      return Promise.reject(new Error(`Unexpected config key: ${key}`))
+    })
+
+    const controller = new FileController(
+      { writeFile, resolveFileUrl: vi.fn() } as any,
+      { getAndValidMultipartField } as any,
+      { createPendingReference } as any,
+      { get } as any,
+    )
+
+    await expect(
+      controller.upload({ type: 'image' } as any, {} as any),
+    ).rejects.toMatchObject({
+      bizCode: ErrorCodeEnum.ImageStorageNotConfigured,
+    })
+
+    expect(getAndValidMultipartField).not.toHaveBeenCalled()
+    expect(writeFile).not.toHaveBeenCalled()
+    expect(createPendingReference).not.toHaveBeenCalled()
+  })
+})
