chore: replace Lerna w/ Release Please #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use Turbo for task runner
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
AdamJaggard
reviewed
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use Turbo for task runner.
This change replaces Lerna with https://github.com/googleapis/release-please for releasing our Mux elements packages.
We started using Lerna right before it was deprecated and then saved and taken over by nrwl lerna/lerna#3121
Since then we haven't updated from v4, current version is v8, to avoid breaking things.
With the creation of the media-elements monorepo and the player.style monorepo we started using Release Please which turned out to be a good experience. There is no local version bump needed and manual GH action triggers etc. but keeps the good parts like use of conventional commits and a confirmation step with an auto created release PR.
Canaries are still done via the publish.sh script but I'm happy to move that over to use wet-run if y'all are on board. It will create provenance NPM versions and the canary prerelease numbers will actually increment which is broken at the moment. The SHA hash is not needed anymore because of the provenance statements https://docs.npmjs.com/generating-provenance-statements