|
1 | 1 | # Open or update a PR |
2 | 2 |
|
3 | | -A request to open or ship a PR authorizes these steps after validation: |
4 | | - |
5 | | -- Branch creation. |
6 | | -- Commits. |
7 | | -- Push. |
8 | | -- PR creation. |
9 | | - |
10 | | -Apply authorization already given. Merging and releasing need separate authorization. |
| 3 | +After validation, a request to open or ship a PR authorizes branch creation, commits, push, and PR creation. Merging and releasing need separate authorization. |
11 | 4 |
|
12 | 5 | ## Validate |
13 | 6 |
|
14 | 7 | Follow [validation](testing.md). |
15 | 8 | Record the `check:affected --run --head` receipt in the PR body. A serialized gate stage can validate the pushed head instead. |
16 | | -For unresolved failures, follow the blocked-validation table. |
17 | 9 | An authorized incomplete draft can record a blocker. A blocker is not a pass. |
18 | 10 | Push once per review round. Each push restarts CI. Drafts skip device lanes. |
19 | 11 |
|
20 | 12 | For device-facing changes, follow [device verification](device-verification.md). |
21 | | -Prove the changed route ran live. Fixtures and adjacent routes do not replace this evidence. |
22 | 13 | Report missing devices or commands. |
23 | 14 |
|
24 | 15 | - Published: the branch is pushed, the PR is open, and validation status is recorded at a named commit. |
25 | | -- Merge-ready: required checks pass at the actual head, with live evidence for device-facing changes. |
| 16 | +- Merge-ready: required checks pass at the head, with live evidence for device-facing changes. |
26 | 17 |
|
27 | 18 | Do not wait for CI merely to report publication. |
28 | | -Do not claim that skipped integration or coverage passed. |
| 19 | +Do not report skipped integration or coverage as passed. |
| 20 | + |
| 21 | +## New public package |
| 22 | + |
| 23 | +A new public package under `packages/` needs a safe transition on npm before its PR merges. |
| 24 | +First, the maintainer publishes an empty placeholder version, for example `0.0.0`, under a dist-tag other than `latest`. |
| 25 | +Then the maintainer configures the npm trusted publisher for the release workflow. |
| 26 | +Only after these steps does the PR remove `"private": true`. |
29 | 27 |
|
30 | 28 | ## Self-review |
31 | 29 |
|
32 | | -Commit the change. |
33 | 30 | Give an independent reviewer the worktree, the merge-base SHA, the head SHA, and the task requirements. |
34 | 31 | In the first review, do not supply an implementation summary. |
35 | 32 | Review that SHA range with AGENTS.md and [review guidance](review.md). |
@@ -57,7 +54,7 @@ After a rebase, validate the new head. Keep old evidence attributed to its origi |
57 | 54 |
|
58 | 55 | ## PR body |
59 | 56 |
|
60 | | -Use ready-for-review by default. When requested or intentionally incomplete, use draft. |
| 57 | +Use ready-for-review by default. Use draft when requested or incomplete. |
61 | 58 | Keep the body below 250 words: |
62 | 59 |
|
63 | 60 | - `## Summary`: include: |
|
0 commit comments