Fix #11325 and refactor score movement handling code#28072
Closed
godalming123 wants to merge 3 commits intomusescore:masterfrom
Closed
Fix #11325 and refactor score movement handling code#28072godalming123 wants to merge 3 commits intomusescore:masterfrom
godalming123 wants to merge 3 commits intomusescore:masterfrom
Conversation
Collaborator
cbjeukendrup
left a comment
There was a problem hiding this comment.
I've asked the design team to check whether this achieves the desired behaviour (also partly to be sure that the "desired" behaviour specified back then is still actually desired).
Meanwhile, some code comments below.
Author
|
@cbjeukendrup thanks for your suggestions, they should all be followed now. |
Closed
8 tasks
Author
|
I've squashed and rebased this patch with the commits from the latest upstream master to fix visual test failure. Here is the new PR: #28138. |
Collaborator
|
(Hint for next time: rebasing and then force-pushing the existing branch is preferred over creating a new PR.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #11325 and reduces repetitive code to handle score movement