Qt 6.8 preparation: Qt::UniqueConnection can only be used with QObject member functions#25343
Merged
cbjeukendrup merged 1 commit intomusescore:masterfrom Apr 30, 2025
Conversation
cbjeukendrup
force-pushed
the
qt68_prep/unique_connection
branch
from
4cad687 to
933434f
Compare
| alignTopLevelToolBars(page); | ||
|
|
||
| if (!m_pageConnections.contains(page)) { | ||
| m_pageConnections[page] = new UniqueConnectionHolder(page, this); |
Contributor
There was a problem hiding this comment.
Where are they deleted?
Collaborator
Author
There was a problem hiding this comment.
In the QObject destructor of the DockWindow :)
(because we set the parent to this, and the QObject destructor deletes child objects)
igorkorsukov
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been the case always, but only since a few Qt versions it causes an assertion failure.
This is my quick-and-dirty fix cherry-picked from #25016. I'm not sure if it is the simplest/cleanest thing we can do, but it is the closest equivalent to a capturing lambda.
@Eism I'm aware that this may be obsoleted by your work on the KDDockWidgets 2.1 update; if that's the case, feel free to close this!
Resolves: #24716
Resolves: #25307