Scroll space in Continuous View#21241
Conversation
| // contentRect is Vertically or Horizontally larger than viewport | ||
| // 1) Continuous Horizontal View | ||
| if (notation()->viewMode() == engraving::LayoutMode::LINE && viewport.width() < contentRect.width()) { | ||
| return notationContentRect().adjusted(0, -overscrollY, 0, overscrollY); |
There was a problem hiding this comment.
This solution has two potential disadvantages:
- if
viewport.width() < contentRect.width()andviewport.height() < contentRect.height(), you would expect that the non-adjustednotationContentRect()is returned, but instead you getnotationContentRect().adjusted(0, -overscrollY, 0, overscrollY); - if
viewport.width()is just slightly larger thancontentRect.width(), then it will immediately be possible to scroll all the way past the end of the notation.
Would it be an idea to change only the line where overscrollFactor is defined, so that it is SCROLL_LIMIT_OFF_OVERSCROLL_FACTOR when the scroll area is not limited and the view mode is not continuous view, and 0.0 otherwise?
There was a problem hiding this comment.
Change in overscrollFactor conflicts with possible zoom out percentage. To overcome removing zoom out percentages, I implemented user can scroll horizontally or vertically to page border only if page fits into viewbox. If page is smaller than view box than he can scroll outside as well.
I will look into your idea once again
igorkorsukov
force-pushed
the
master
branch
6 times, most recently
from
fa1f8d3 to
525a11a
Compare
RomanPudashkin
requested review from
mathesoncalum
and removed request for
cbjeukendrup
|
Closing - we're going to discuss a couple of design points internally and pick this up as part of #32404. |
3 participants
Resolves: #11325