Linux: Add native Wayland support to AppImage#13781
Merged
RomanPudashkin merged 1 commit intomusescore:masterfrom May 10, 2023
Merged
Linux: Add native Wayland support to AppImage#13781RomanPudashkin merged 1 commit intomusescore:masterfrom
RomanPudashkin merged 1 commit intomusescore:masterfrom
Conversation
shoogle
force-pushed
the
appimage-wayland
branch
2 times, most recently
from
86dce60 to
b8dc3cd
Compare
shoogle
changed the title
igorkorsukov
approved these changes
Dec 26, 2022
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 18, 2023
will be included automatically in the appimage when musescore#13781 is merged
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 19, 2023
will be included automatically in the appimage when musescore#13781 is merged
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 19, 2023
will be included automatically in the appimage when musescore#13781 is merged
Contributor
|
Ciao, Should we check that m_stack[i].window is not 0 before accessing it?(so basically perform this check: if (m_stack[i].window && m_stack[i].window->isWidgetType()) { )I tested this and it avoids the crash, but I don't know if the problem should or could be tackled before reaching this point. |
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 21, 2023
will be included automatically in the appimage when musescore#13781 is merged
igorkorsukov
pushed a commit
that referenced
this pull request
Jan 23, 2023
will be included automatically in the appimage when #13781 is merged
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 26, 2023
will be included automatically in the appimage when musescore#13781 is merged
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Jan 26, 2023
will be included automatically in the appimage when musescore#13781 is merged
octopols
pushed a commit
to octopols/MuseScore
that referenced
this pull request
Jan 31, 2023
will be included automatically in the appimage when musescore#13781 is merged
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Mar 14, 2023
will be included automatically in the appimage when musescore#13781 is merged
Fix musescore#11244 To use the Wayland display protocol rather than X11, firstly you must be running Wayland as your display server. Many Linux distributions allow you to choose between Wayland and X.org/X11 at the login screen. Use this command to find out which server you are currently using: echo $XDG_SESSION_TYPE Secondly, when you run MuseScore, you must opt-in to Wayland support, either via an environment variable: QT_QPA_PLATFORM=wayland ./MuseScore*.AppImage Or via a command line option: ./MuseScore*.AppImage -platform wayland Otherwise Qt will default to running in X11 mode via the Xwayland compatibility layer, which is more reliable than native Wayland support in some cases (particularly on older distributions).
|
|
||
| # Semicolon-separated list of needed .so files in Qt's platform/plugins | ||
| # directory for linuxdeploy-plugin-qt to scan and deploy. | ||
| export EXTRA_PLATFORM_PLUGINS="libqwayland-egl.so;libqwayland-generic.so" |
Collaborator
There was a problem hiding this comment.
This change conflicts with a recent change a few lines above this: see line 107
export EXTRA_PLATFORM_PLUGINS=libqoffscreen.so
Contributor
Author
There was a problem hiding this comment.
Oh, sorry! I didn't notice. I'll fix that now.
8 tasks
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Dec 11, 2023
wayland platform plugins currently deployed in the CI are built on ubuntu focal and only compatible with wayland prior to 1.20. Attempting to run the appimage on modern wayland DEs results in a symbol lookup error musescore#18598 so disable for now until a workaround is implemented in a future release effectively a revert of musescore#13781
theofficialgman
added a commit
to theofficialgman/MuseScore
that referenced
this pull request
Dec 11, 2023
wayland platform plugins currently deployed in the CI are built on ubuntu focal and only compatible with wayland prior to 1.20. Attempting to run the appimage on modern wayland DEs results in a symbol lookup error and failure to run musescore#18598 so disable for now until a workaround is implemented in a future release effectively a revert of musescore#13781
shoogle
pushed a commit
that referenced
this pull request
Dec 11, 2023
wayland platform plugins currently deployed in the CI are built on ubuntu focal and only compatible with wayland prior to 1.20. Attempting to run the appimage on modern wayland DEs results in a symbol lookup error and failure to run #18598 so disable for now until a workaround is implemented in a future release effectively a revert of #13781
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 25, 2023
wayland platform plugins currently deployed in the CI are built on ubuntu focal and only compatible with wayland prior to 1.20. Attempting to run the appimage on modern wayland DEs results in a symbol lookup error and failure to run musescore#18598 so disable for now until a workaround is implemented in a future release effectively a revert of musescore#13781
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11244
To use the Wayland display protocol rather than X11, firstly you must be running Wayland as your display server. Many Linux distributions allow you to choose between Wayland and X.org/X11 at the login screen. Use this command to find out which server you are currently using:
Secondly, when you run MuseScore, you must opt-in to Wayland support, either via an environment variable:
QT_QPA_PLATFORM=wayland ./MuseScore*.AppImageOr via a command line option:
./MuseScore*.AppImage -platform waylandOtherwise Qt will default to running in X11 mode via the Xwayland compatibility layer, which is more reliable than native Wayland support in some cases (particularly on older distributions).