Skip to content

Commit 49e6e60

Browse files
committed
feat(es-app): integrate failure-scan bounds (anomalyco#247) and agent-originated resume rendering
2 parents 346e5a9 + bc5c48c commit 49e6e60

4 files changed

Lines changed: 41 additions & 8 deletions

File tree

‎packages/es-app/src/components/transcript-message.tsx‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createMemo, createSignal, For, Index, Show, type ComponentProps, type J
22
import { Message } from "@opencode-ai/session-ui/message-part"
33
import { errorText } from "../live-session"
44
import type { MailDelivery, MailMessage } from "../api"
5-
import { mailSentAt, mailWake } from "../mail-timeline"
5+
import { mailActivityLabel, mailSentAt, mailWake } from "../mail-timeline"
66
import { MailWakeEvidence } from "./mail-wake-evidence"
77
import type { Segment } from "../transcript-groups"
88

@@ -19,10 +19,11 @@ const mailMetadata = (message: ComponentProps<typeof Message>["message"]) => {
1919
!("sender" in source) || typeof source.sender !== "string" ||
2020
!("recipient" in source) || typeof source.recipient !== "string") return
2121
const mail: MailSource = { type: "editspace-mail", id: source.id, sender: source.sender, recipient: source.recipient }
22+
const label = mailActivityLabel("kind" in source ? source.kind : undefined)
2223
const delivery = "delivery" in message && (message.delivery === "queue" || message.delivery === "steer") ? message.delivery : undefined
2324
const state = "state" in message &&
2425
(message.state === "pending" || message.state === "promoted" || message.state === "cancelled") ? message.state : undefined
25-
return { mail, delivery, state }
26+
return { mail, delivery, state, label }
2627
}
2728

2829
export const TranscriptMessage = (props: ComponentProps<typeof Message> & {
@@ -86,7 +87,7 @@ export const TranscriptMessage = (props: ComponentProps<typeof Message> & {
8687
</Show>}>
8788
{(metadata) => <details class="mail-activity" id={`mail-${metadata().mail.id}`} data-mail-message-id={props.message.id}>
8889
<summary class="mail-activity-summary">
89-
<span class="mail-activity-kind">Mail<Show when={props.mailRecord}> · {props.mailRecord?.direction === "sent" ? "Outbound" : "Inbound"}</Show></span>
90+
<span class="mail-activity-kind">{metadata().label}<Show when={props.mailRecord}> · {props.mailRecord?.direction === "sent" ? "Outbound" : "Inbound"}</Show></span>
9091
<span class="mail-activity-route"><bdi dir="auto">{metadata().mail.sender}</bdi> <span class="mail-activity-arrow" aria-hidden="true">→</span> <bdi dir="auto">{metadata().mail.recipient}</bdi></span>
9192
<span class="mail-activity-state">
9293
<For each={props.mailDeliveries ?? []}>{(delivery) => <span>{mailWake(delivery)} · {delivery.state}</span>}</For>

‎packages/es-app/src/mail-timeline.test.ts‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect, test } from "bun:test"
22
import type { Message } from "@opencode-ai/sdk/v2"
33
import type { MailMessage, MailTimeline } from "./api"
4-
import { mailCauses, mailForSession, mailLocation, mailRows, mailWake } from "./mail-timeline"
4+
import { mailActivityLabel, mailCauses, mailForSession, mailLocation, mailRows, mailWake } from "./mail-timeline"
55

66
test("selects the matching editspace and lane from the session directory", () => {
77
const roots = [
@@ -188,3 +188,19 @@ test("a mail run without its source record reports no send time rather than inve
188188
expect(mailCauses(mailRows(messages, undefined), new Map()).get("msg_m")).toEqual({
189189
ids: ["gone"], kinds: [{ kind: "mail", human: false, catchUp: false, count: 1 }], senders: ["peer"], promotedAt: 5_000 })
190190
})
191+
192+
test("labels agent-originated resume and kickoff inputs by what the agent did", () => {
193+
expect(mailActivityLabel("resume")).toBe("Agent resume")
194+
expect(mailActivityLabel("spawn")).toBe("Agent kickoff")
195+
expect(mailActivityLabel("task")).toBe("Mail")
196+
expect(mailActivityLabel(undefined)).toBe("Mail")
197+
})
198+
199+
test("keeps an agent resume in the session transcript although no mail record exists", () => {
200+
const source = { type: "editspace-mail", id: "es-resume-1", sender: "orchestrator", recipient: "work", kind: "resume" }
201+
const resume = { id: "msg_resume", sessionID: "ses_first", role: "user", time: { created: 3000 }, source } as unknown as Message
202+
const stale = { id: "msg_mail", sessionID: "ses_first", role: "user", time: { created: 3000 },
203+
source: { ...source, id: "gone", kind: "task" } } as unknown as Message
204+
expect(mailRows([resume, stale], undefined, [], { sessionID: "ses_first", from: 2000 }).map(row => row.message.id))
205+
.toEqual(["msg_resume"])
206+
})

‎packages/es-app/src/mail-timeline.ts‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,16 @@ export const mailSourceID = (message: Message) => {
3232
return source.id
3333
}
3434

35+
// es admits an agent's `resume` or spawn kickoff text as sourced input so it
36+
// is never mistaken for the human; name it by what the agent did.
37+
export const mailActivityLabel = (kind: unknown) =>
38+
kind === "resume" ? "Agent resume" : kind === "spawn" ? "Agent kickoff" : "Mail"
39+
40+
// These inputs have no mail record, so they are transcript content in their own right.
41+
const agentInput = (message: Message) => !!mailSourceID(message) && "source" in message &&
42+
typeof message.source === "object" && message.source !== null && "kind" in message.source &&
43+
mailActivityLabel(message.source.kind) !== "Mail"
44+
3545
export type MailInterval = { sessionID: string; lane?: string; from?: number; to?: number }
3646

3747
// Receipt/admission times never move historical source content into a new session.
@@ -74,7 +84,7 @@ export const mailRows = (messages: Message[], timeline: MailTimeline | undefined
7484
// Keep raw history intact. Mail with unavailable/old source time is not transcript content.
7585
const visible = interval ? messages.filter(message => {
7686
const id = mailSourceID(message)
77-
return !id || records.has(id)
87+
return !id || records.has(id) || agentInput(message)
7888
}) : messages
7989
const existing = new Map(previous.map((row) => [`${row.type}:${row.message.id}`, row]))
8090
const promoted = new Set(visible.flatMap((message) => {

‎packages/es-app/test/mail-activity.browser.mjs‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,28 @@ fixture.messages = [
1414
user("msg_002", "Synthetic notice is not mail", { source: { type: "other", id: "mail-42", sender: "fake", recipient: "fake" } }),
1515
user("msg_003", "Mail body with <img src=x onerror=alert(1)>", { source, delivery: "queue", state: "promoted" }),
1616
user("msg_004", "Mail without delivery metadata", { source: { ...source, id: "mail-43" } }),
17+
user("msg_005", "Joiner finished the report", { source: { ...source, id: "es-resume-1", kind: "resume", senderSession: "ses_orch" } }),
1718
]
1819
fixture.mail = (es, recipient) => ({ editspace: es, lane: "", messages: recipient === "ses_a" ? [
1920
{ id: "mail-42", ts: new Date(1).toISOString(), created_ms: 1, from: "lane-alpha", to: "lane-beta",
2021
direction: "received", text: "Mail body with <img src=x onerror=alert(1)>", deliveries: [] },
2122
{ id: "mail-43", ts: new Date(1).toISOString(), created_ms: 1, from: "lane-alpha", to: "lane-beta",
2223
direction: "received", text: "Mail without delivery metadata", deliveries: [] },
2324
] : [] })
24-
const browser = await chromium.launch({ channel: "chrome", headless: true })
25+
const browser = await chromium.launch({ headless: true,
26+
...(process.env.CHROMIUM_EXECUTABLE ? { executablePath: process.env.CHROMIUM_EXECUTABLE } : { channel: "chrome" }) })
2527
const page = await browser.newPage({ viewport: { width: 1440, height: 900 } })
2628
await page.context().route("**/*", route => new URL(route.request().url()).origin === preview.origin ? route.continue() : route.abort())
2729
const errors = []
2830
page.on("pageerror", error => errors.push(error.message))
2931
try {
3032
await page.goto(preview.url)
3133
const mail = page.locator('[data-mail-message-id="msg_003"]')
32-
await expect(page.locator(".mail-activity")).toHaveCount(2)
34+
await expect(page.locator(".mail-activity")).toHaveCount(3)
35+
// An agent's resume is agent-originated activity, never a human turn.
36+
await expect(page.locator('[data-mail-message-id="msg_005"] summary')).toContainText("Agent resume")
37+
await expect(page.locator('[data-mail-message-id="msg_005"] summary')).toContainText("lane-alpha → lane-beta")
38+
await expect(mail.locator("summary")).toContainText("Mail")
3339
await expect(page.locator('.transcript [data-component="user-message"]:not(.mail-activity [data-component="user-message"])')).toHaveCount(2)
3440
await expect(mail.locator("summary")).toContainText("lane-alpha → lane-beta")
3541
await expect(mail.locator("summary")).toContainText("queue")
@@ -45,7 +51,7 @@ try {
4551
await expect(page.locator('.transcript [data-component="user-message"]:not(.mail-activity [data-component="user-message"])')).toContainText(["Human: mail-42", "Synthetic notice is not mail"])
4652
expect(errors).toEqual([])
4753
expect(fixture.calls.filter(call => !["GET", "HEAD", "OPTIONS"].includes(call.method))).toEqual([])
48-
console.log("PASS mail activity: structured source only, delivery/state, expandable original, safe text, no mutations")
54+
console.log("PASS mail activity: structured source only, agent resume labelled, delivery/state, expandable original, safe text, no mutations")
4955
} finally {
5056
await browser.close()
5157
await preview.close()

0 commit comments

Comments
 (0)