Feature: GeometryEdgeFinder#386
Merged
Merged
Conversation
Helper function that makes edges into Shapes A helper function that makes edges (1 cell thick) into Shapes, allowing the user to easily define things for e.g. custom fields boundary conditions. By default, 6 shapes: +/- X,Y, Z 2s permutations (corners such as +/- XY, etc) can be done by using existing shape method .intersect(). 3s as well. e.g.: (+X/+Y corner) plusXplusY := plusX.Intersect(plusY) or (+X/+Y/+Z corner) plusX.Intersect(plusY).Intersect(plusZ) Does *not* check if PBC are enabled.
JonathanMaes
requested changes
Mar 25, 2026
add ext_ to name since it may not play well with mesh/geom changes. clarify description use string switches instead of 6 functions for each direction move d outside func()
ilateur
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a helper function that makes edges of the geometry (1 cell thick) into Shapes, allowing the user to easily define things for e.g. custom fields boundary conditions. By default, there are 6 Shapes corresponding to: +/- X, Y, Z edges.