Skip to content

allow to combine arrows with scalar colormaps #152

Merged
barnex merged 2 commits into
masterfrom
mumax3-convert/arrows-vs-scalar-color
Jan 25, 2018
Merged

allow to combine arrows with scalar colormaps #152
barnex merged 2 commits into
masterfrom
mumax3-convert/arrows-vs-scalar-color

Conversation

@godsic

@godsic godsic commented Jan 25, 2018

Copy link
Copy Markdown
Contributor

Before this change mumax3-convert would normally output either:

m_xrange192-320_yrange192-320_012500

or

m_xrange192-320_yrange192-320_012500

After this change one can do something like this:
m_xrange192-320_yrange192-320_012500

@godsic
godsic requested a review from a team January 25, 2018 16:08
@godsic

godsic commented Jan 25, 2018

Copy link
Copy Markdown
Contributor Author

@barnex not sure it is done in idiomatic way, but seems like this is the most compact version.

@barnex barnex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@barnex
barnex merged commit e2c09f4 into master Jan 25, 2018
@barnex

barnex commented Jan 25, 2018

Copy link
Copy Markdown
Member

Thanks.

@JonathanMaes
JonathanMaes deleted the mumax3-convert/arrows-vs-scalar-color branch October 7, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants