fix: use safe port range for local cluster postgres instances#353
Merged
rafael merged 10 commits intomultigres:mainfrom Dec 23, 2025
Merged
fix: use safe port range for local cluster postgres instances#353rafael merged 10 commits intomultigres:mainfrom
rafael merged 10 commits intomultigres:mainfrom
Conversation
Fixes multigres#351 This change addresses two issues when bringing up a local cluster: 1. Backend Postgres instances now use ports 25432-25434 instead of 5432-5434, avoiding conflicts with local Postgres installations. 2. Multigateway PG ports for zones 2 and 3 now correctly use 15433 and 15434 instead of incorrectly using 5433 and 5434. Changes: - Added DefaultLocalPostgresPort (25432) constant to ports.go - Updated DefaultConfig in config.go to use the new port constants - Updated fallback defaults in local.go and pgctld.go - Added TestDefaultConfigPorts test to prevent regression Signed-off-by: amankumarpandeyin <[email protected]>
ixchio
force-pushed
the
fix/local-cluster-port-assignment
branch
from
b048282 to
6a3da61
Compare
Pull Request Test Coverage Report for Build 20451734589Details
💛 - Coveralls |
ixchio
force-pushed
the
fix/local-cluster-port-assignment
branch
from
0cb54bf to
1dc1637
Compare
The second break attempt was racing with multiorch's recovery cycle, causing intermittent failures. The first break/verify cycle already proves the mechanism works; the second only needs to verify repeatability of the fix. Signed-off-by: amankumarpandeyin <[email protected]>
Collaborator
|
This change looks good to me. Could you fix the DCO so we can merge? |
…n_Standby_Fails test The test doesn't need replication configured - it only validates that ConfigureSynchronousReplication fails on a standby node. Without this option, cleanup would timeout trying to restore replication state. Signed-off-by: amankumarpandeyin <[email protected]>
ixchio
force-pushed
the
fix/local-cluster-port-assignment
branch
from
3f97522 to
1243835
Compare
Contributor
Author
@rafael Done.......I’ve fixed the DCO and updated the commits. |
Contributor
Author
|
All set. DCO fixed, commits updated, and tests are green.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Summary
This PR addresses two issues when bringing up a local cluster:
Backend Postgres port conflict: Postgres instances now use ports
25432-25434instead of5432-5434, avoiding conflicts with local Postgres installations.Inconsistent Multigateway ports: Multigateway PG ports for zones 2 and 3 now correctly use
15433and15434instead of incorrectly using5433and5434.Changes
DefaultLocalPostgresPort = 25432TestDefaultConfigPortsto prevent regressionPort Assignments After This Fix
Testing
TestDefaultConfigPortsto verify correct port assignments