Repository navigation
fix(daemon): print a size that rounds to 1024 KB in MB - #10431
Conversation
|
@kevin9327 is attempting to deploy a commit to the IndexLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
Please add a screenshot or screen recording from the running app showing the skill-download task failure details and the affected size message. This PR changes user-visible error text from The pull request requirements require running-app evidence for UI or interaction changes, including error messages. UI or interaction PRs are not reviewed until screenshots or a screen recording are added. Please update the PR description with the capture. This comment was posted automatically by an agent in Multica and may contain mistakes. A maintainer will follow up. |
|
Thanks. I can't run a full Multica stack and force a skill download to fail, so I have no capture from the app itself. I added a before/after of the message text to the description instead, built from the old and new |
…onnections * upstream/main: (42 commits) feat(dev): realtime events, cache and agent panels in the dev toolbar (MUL-9139) (multica-ai#10470) MUL-9086: add Amp CLI harness support (multica-ai#10477) fix(autopilots): store no next run for a schedule that never fires (multica-ai#10239) fix(scripts): 安装脚本在查版失败和切库失败时不再谎报成功 (multica-ai#10246) MUL-9142: fix(zcode): run Linux desktop CLI headlessly (multica-ai#10476) MUL-9141 fix(hermes): preserve model discovery through confirmations (multica-ai#10478) feat(chat): persist optional submission acceptance receipts (multica-ai#10469) fix(daemon): reuse checkout when repo checkout runs from inside it (MUL-9099) (multica-ai#10465) fix(daemon): clear the client user id on daemon-token requests (multica-ai#10333) MUL-9085: add Factory Droid harness (multica-ai#10399) perf(web): cache locale dictionaries by language (MUL-9114) (multica-ai#10473) MUL-8992: fix(server): keep background runs and workspace-wide reads inside private projects (multica-ai#10329) feat(views): show linked pull requests across issue view layouts (multica-ai#10351) EDEN-20: add confirmed deletion of inbox entries (multica-ai#10356) fix(usage): price GLM-5.3, Kimi K3.1 Pro, Gemini 4 Carbon, and Antigravity Claude effort ids (multica-ai#10445) fix(agents): wake the runtime when an agent's concurrency cap changes (multica-ai#10463) MUL-7703 feat(issues): add Idle to Agent status filter (multica-ai#10461) fix(agent): probe Hermes version with acp --version (MUL-9132) (multica-ai#10468) feat(desktop): right-click on the issue page opens its actions menu (MUL-9093) (multica-ai#10467) fix(daemon): print a size that rounds to 1024 KB in MB (multica-ai#10431) ... # Conflicts: # server/pkg/agent/zcode_invocation.go # server/pkg/agent/zcode_runtime_config.go
Problem
When a skill bundle download fails, the daemon's error message shows the bundle size through
formatBytes. Sizes from 1,048,064 bytes up to 1,048,575 bytes (1023.5 KB to just under 1 MB) fall in the KB branch, and%.0frounds them up, so the message reads1024 KBinstead of1.00 MB. Anyone reading a failed-download message for a bundle near 1 MB sees a size in the wrong unit.Goal
A size that would round to 1024 KB prints in MB, so the KB branch never shows
1024 KB.Proposal
Move the KB/MB cut-off in
formatBytes(server/internal/daemon/daemon.go) down to the first byte count that rounds to 1024 KB, which is 1 MiB minus 512 bytes. Sizes below it print exactly as before.TestFormatBytesgains three cases at the boundary: 1,048,063 bytes stays1023 KB, and 1,048,064 and 1,048,575 bytes print1.00 MB. The two new MB cases fail onmainwith"1024 KB"and pass with this change.Screenshots
I don't have a running Multica deployment where I can make a skill download fail on purpose, so I can't attach a capture from the app. Here is the text the failure message would carry, before and after, for a declared size of 1,048,200 bytes. It comes from a standalone copy of
formatBytes(old and new) dropped into thedescribeSkillBundleFailureformat string, not from the app itself:This change was written with AI assistance; I reviewed it and ran
go test ./internal/daemon -run TestFormatBytesbefore and after the fix.Closes MUL-9117