rename focal_alpine image to alpine_x86_64

The deploy.sh script takes only one argument for the $PLATFORM so in PR #20 that took on the name alpine resulting in a focal_alpine docker tag. It would be nice to refactor this to use a $DISTRO, with a default of focal.

docker-images/deploy.sh

Lines 1 to 8 in 5a2fae9

    
           #!/bin/bash 
        
           set -ex 
        
           docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD" 
        
           build="multibuild/focal_$PLATFORM" 
        
           docker tag ${build}:${TRAVIS_COMMIT} ${build}:latest 
        
           docker push ${build}:${TRAVIS_COMMIT} 
        
           docker push ${build}:latest

@stefanv

@stefanv ?

The distinction between Alpine and Ubuntu seems less the distribution than the libc being used. If you think $DISTRO is the right way to go, I'm happy to make that modification; otherwise $LIBC?

I'll do the $DISTRO thing for now, and we can refactor later.

Navigation Menu

Repository navigation

rename focal_alpine image to alpine_x86_64 #21

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	#!/bin/bash
	set -ex

	docker login -u "$DOCKER_USERNAME" -p "$DOCKER_PASSWORD"
	build="multibuild/focal_$PLATFORM"
	docker tag ${build}:${TRAVIS_COMMIT} ${build}:latest
	docker push ${build}:${TRAVIS_COMMIT}
	docker push ${build}:latest

rename focal_alpine image to alpine_x86_64 #21

Description

Activity

mattip commented on Oct 13, 2021

stefanv commented on Oct 13, 2021

stefanv commented on Oct 13, 2021

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions