Remove tslib dependency from packages#832
Merged
Merged
Conversation
Bumps [tslib](https://github.com/Microsoft/tslib) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/Microsoft/tslib/releases) - [Commits](microsoft/tslib@2.0.3...2.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
oliviertassinari
force-pushed
the
dependabot/npm_and_yarn/tslib-2.1.0
branch
from
January 10, 2021 16:22
006f636 to
2056f89
Compare
dtassone
approved these changes
Jan 11, 2021
DanailH
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit by @oliviertassinari
It looks like tslib was added by mistake in #44 and #103. If it was on purpose we need to talk about the process. A case needs to be made before we add/remove dependencies. It should happen into a single focus pull request (not inside a large refactoring mixing different things).
As far as I understand it, tslib shouldn't be present because:
--importHelpersoption which we don't: https://www.npmjs.com/package/tslib.@babel/runtimeshould be used (for consistency with the other components & minimizing bundle size).Closes #47