Skip to content

[internal] Improve the playground DX#6514

Merged
oliviertassinari merged 1 commit into
mui:nextfrom
oliviertassinari:improve-playground
Oct 19, 2022
Merged

[internal] Improve the playground DX#6514
oliviertassinari merged 1 commit into
mui:nextfrom
oliviertassinari:improve-playground

Conversation

@oliviertassinari

Copy link
Copy Markdown
Member

A continuation of #6466 based on mui/material-ui#34739

@oliviertassinari oliviertassinari added the internal Behind-the-scenes enhancement. Formerly called “core”. label Oct 14, 2022
Comment thread .eslintignore
Comment on lines +7 to -9
build
CHANGELOG.md
dist
node_modules
build

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort asc

Comment thread docs/package.json
"build": "cross-env NODE_ENV=production next build --profile",
"build:clean": "rimraf .next && yarn build",
"build-sw": "node ./scripts/buildServiceWorker.js",
"dev": "rimraf ./node_modules/.cache/babel-loader && next dev --port 3001",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread package.json
Comment on lines +5 to +9
"start": "yarn && yarn docs:dev",
"benchmark:browser": "yarn workspace benchmark browser",
"docs:dev": "yarn workspace docs dev",
"docs:start": "yarn workspace docs start",
"docs:create-playground": "yarn workspace docs create-playground",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui-bot

mui-bot commented Oct 14, 2022

Copy link
Copy Markdown

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 501 1,023 557.2 745.7 204.445
Sort 100k rows ms 560 1,485.9 808.4 903.24 308.886
Select 100k rows ms 159.8 247.5 196.6 201.82 29.706
Deselect 100k rows ms 138.8 267.6 191.8 202.18 46.986

Generated by 🚫 dangerJS against 198ca44

Comment thread .gitignore

@LukasTy LukasTy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👌 👍

@oliviertassinari
oliviertassinari merged commit 4488896 into mui:next Oct 19, 2022
@oliviertassinari
oliviertassinari deleted the improve-playground branch October 19, 2022 11:37
@oliviertassinari

oliviertassinari commented Oct 19, 2022

Copy link
Copy Markdown
Member Author

m4theushw added a commit to m4theushw/mui-x that referenced this pull request Oct 20, 2022
commit 634aabe
Author: Matheus Wichman <[email protected]>
Date:   Wed Oct 19 20:26:54 2022 -0300

    Update migration guide

commit 40bbeef
Merge: d49de67 4fbb67d
Author: Matheus Wichman <[email protected]>
Date:   Wed Oct 19 11:07:48 2022 -0300

    Merge branch 'next' into rename-selection-props

commit 4fbb67d
Author: Danail Hadjiatanasov <[email protected]>
Date:   Wed Oct 19 15:26:21 2022 +0300

    [test] Remove BrowserStack (mui#6263)

commit fff240b
Author: Olivier Tassinari <[email protected]>
Date:   Wed Oct 19 14:18:46 2022 +0200

    [core] Fix trailing spaces and git diff format (mui#6523)

    Signed-off-by: Olivier Tassinari <[email protected]>

commit 4488896
Author: Olivier Tassinari <[email protected]>
Date:   Wed Oct 19 13:37:09 2022 +0200

    [core] Improve the playground DX (mui#6514)

commit e195e5a
Author: Olivier Tassinari <[email protected]>
Date:   Wed Oct 19 13:30:12 2022 +0200

    [core] Link Netlify in the danger comment (mui#6513)

commit a4fedc1
Author: Alexandre Fauquette <[email protected]>
Date:   Wed Oct 19 11:57:42 2022 +0200

    [adapters] Fix localisation of the placeholder (mui#6547)

commit d49de67
Author: Matheus Wichman <[email protected]>
Date:   Tue Oct 18 19:17:48 2022 -0300

    [DataGrid] Rename selection props
@oliviertassinari oliviertassinari changed the title [core] Improve the playground DX [internal] Improve the playground DX Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants