[test] Remove BrowserStack#6263
Merged
Merged
Conversation
DanailH
added
the
internal
DanailH
requested review from
flaviendelangle,
m4theushw and
oliviertassinari
September 23, 2022 11:50
These are the results for the performance tests:
|
Collaborator
|
Do we need to remove BrowserStack? The latest builds are most green again, the red ones are becoming rare and they are not because a test failed.
|
Member
Author
In that case, we don't. The current setup has |
oliviertassinari
approved these changes
Oct 9, 2022
oliviertassinari
changed the title
DanailH
marked this pull request as ready for review
October 11, 2022 07:49
Member
Author
|
@m4theushw @flaviendelangle If you can have a look once you have the time it would be great. |
|
|
||
| describe('component: GridToolbar', () => { | ||
| it('should export with the default csvOptions', async function test() { | ||
| // Safari 13 doesn't have Blob.text(). |
Member
There was a problem hiding this comment.
So a bug? https://mui.com/material-ui/getting-started/supported-platforms/#browser says we support Safari 13
Member
Author
There was a problem hiding this comment.
I couldn't find cases where Blob.text() is being used.
Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
…l-ui-x into core/remove-BrowserStack
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
removed
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
m4theushw
added a commit
to m4theushw/mui-x
that referenced
this pull request
Oct 20, 2022
commit 634aabe Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 20:26:54 2022 -0300 Update migration guide commit 40bbeef Merge: d49de67 4fbb67d Author: Matheus Wichman <[email protected]> Date: Wed Oct 19 11:07:48 2022 -0300 Merge branch 'next' into rename-selection-props commit 4fbb67d Author: Danail Hadjiatanasov <[email protected]> Date: Wed Oct 19 15:26:21 2022 +0300 [test] Remove BrowserStack (mui#6263) commit fff240b Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 14:18:46 2022 +0200 [core] Fix trailing spaces and git diff format (mui#6523) Signed-off-by: Olivier Tassinari <[email protected]> commit 4488896 Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:37:09 2022 +0200 [core] Improve the playground DX (mui#6514) commit e195e5a Author: Olivier Tassinari <[email protected]> Date: Wed Oct 19 13:30:12 2022 +0200 [core] Link Netlify in the danger comment (mui#6513) commit a4fedc1 Author: Alexandre Fauquette <[email protected]> Date: Wed Oct 19 11:57:42 2022 +0200 [adapters] Fix localisation of the placeholder (mui#6547) commit d49de67 Author: Matheus Wichman <[email protected]> Date: Tue Oct 18 19:17:48 2022 -0300 [DataGrid] Rename selection props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the previous discussion - if we remove all the browsers from the BrowserStack list should we just remove the BrowserStack condition all together?