[DataGrid] Fix TypeScript definitions published on npm#343
Closed
oliviertassinari wants to merge 3 commits into
Closed
[DataGrid] Fix TypeScript definitions published on npm#343oliviertassinari wants to merge 3 commits into
oliviertassinari wants to merge 3 commits into
Conversation
oliviertassinari
force-pushed
the
yolo
branch
2 times, most recently
from
September 22, 2020 22:53
38e5d71 to
364f540
Compare
Member
Author
|
The issue with
|
oliviertassinari
force-pushed
the
yolo
branch
from
September 22, 2020 23:09
364f540 to
fb28665
Compare
Member
|
Member
Author
|
@mbrookes Right, my bad. I should have been more precise. We need to add the license package as a dependency of x-grid and to not bundle it in the JavaScript asset. |
oliviertassinari
changed the title
oliviertassinari
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on top of #341, exploration for #339.