[x-chat] Fix object URL leaks for submitted attachments#23198
Merged
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
hasdfa
changed the title
hasdfa
marked this pull request as ready for review
July 23, 2026 09:50
Member
Author
|
@codex review |
hasdfa
added
type: bug
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fix an object URL leak when submitting non-image attachments with
@mui/x-chat-headless.What changed
previewUrl.Root cause
Image preview URLs were created when attachments entered the draft and were tracked through the draft and message lifecycles. Non-image URLs were instead created during submission and never registered with either ownership map, leaving no cleanup path.
Validation
Added regression coverage for message removal, composer unmount, and partial construction failure.
Confirmed all three tests fail against the original implementation and pass with the fix.
pnpm test:unit --project "x-chat-headless" --run— 640 passed, 24 skipped.pnpm --filter "@mui/x-chat-headless" run typescriptpnpm eslintpnpm prettierI have followed (at least) the PR section of the contributing guide.