[charts-pro] Fix highlight shifting on sampled bar charts#23190
Merged
Conversation
noraleonte
added
type: bug
Deploy previewBundle size
PerformanceTotal duration: 1,358.36 ms -117.28 ms(-7.9%) | Renders: 63 (+0) | Paint: 1,924.33 ms -122.10 ms(-6.0%)
…and 6 more (+15 within noise) — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
JCQuintas
reviewed
Jul 21, 2026
JCQuintas
left a comment
JCQuintas
left a comment
Member
There was a problem hiding this comment.
Nice work, mostly nit picks
It also seems that argos picked a fix where we were drawing the initial bar from edge rather than from the "gap" 👍
Comment on lines
+76
to
+95
| const geometry = (reverse: boolean) => { | ||
| const { container } = render( | ||
| <BarChartPro | ||
| series={[{ data: range(256) }]} | ||
| xAxis={[{ data: range(256).map(String), zoom: true, reverse }]} | ||
| yAxis={[{ position: 'none' }]} | ||
| width={width} | ||
| height={200} | ||
| margin={0} | ||
| sampling="minmax" | ||
| skipAnimation | ||
| />, | ||
| ); | ||
| return Array.from(container.querySelectorAll(`.${barClasses.element}`)) | ||
| .map((bar) => ({ x: Number(bar.getAttribute('x')), width: Number(bar.getAttribute('width')) })) | ||
| .sort((a, b) => a.x - b.x); | ||
| }; | ||
|
|
||
| const normal = geometry(false); | ||
| const reversed = geometry(true); |
Member
There was a problem hiding this comment.
Not sure it is a good idea to call render twice in the same test 🤔
Probably a more orthodox approach would be to either render both and use selectors for each, or "render, select, update props to reverse, select"
Comment on lines
+25
to
+28
| [ | ||
| { reverse: false, leftIndex: 0 }, | ||
| { reverse: true, leftIndex: 3 }, | ||
| ].forEach(({ reverse, leftIndex }) => { |
Member
There was a problem hiding this comment.
Vitest has a it.for for these cases, but it's not necessary to change 😆
Comment on lines
+37
to
+38
| // Anchor at the left edge: on a reversed axis `data[bucketStart]` is the right-most slot. | ||
| bandStart = Math.min(scale(data[bucketStart])!, scale(data[bucketEnd])!) - halfPadding; |
Member
There was a problem hiding this comment.
Maybe we should have a getBucketRegion(scale, startIndex, endIndex) fn
so that this and the code in createGetBarDimension are synced
JCQuintas
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix sampled bars and axis highlight misaligning on band axes (#22997):
Before:
After:
closes #22997