[test] Track @mui/x-chat bundle size via native expand#23049
Merged
Conversation
Convert the bundle-size-checker config to the checker's native `expand` feature, replacing the bespoke findComponents/findComponentsFromExports helpers with a declarative entrypoint list plus small exclude rules. - Add @mui/x-chat (root + Chat* components). - Drop @mui/x-license/internals from tracking. - Bump @mui/internal-bundle-size-checker to 1.0.9-canary.83.
Deploy previewhttps://deploy-preview-23049--material-ui-x.netlify.app/Bundle size
Check out the code infra dashboard for more information about this PR. |
Janpot
marked this pull request as ready for review
July 3, 2026 10:26
brijeshb42
reviewed
Jul 3, 2026
| // Renderable components are PascalCase; every lowercase-first sub-path export | ||
| // (hooks, models, locales, internals, utils, internals/demo, moduleAugmentation/*, …) | ||
| // is a non-component. A single rule covers them at any depth. | ||
| const componentPackage = { exclude: ['[a-z]*', '[a-z]*/**'] }; |
Contributor
There was a problem hiding this comment.
Are these excluded because they are used in components anyways ?
Member
Author
There was a problem hiding this comment.
They're only excluded because currently they're not being tracked. We can add them, but I would do it separately.
brijeshb42
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@mui/x-chatto the bundle-size checker and converts the config to the checker's nativeexpand, replacing thefindComponents/findComponentsFromExportshelpers.@mui/x-chat(root +Chat*components);@mui/x-chat-headlessstays untracked (hooks-only).@mui/x-license/internals.['[a-z]*', '[a-z]*/**']for component packages (components are PascalCase), plus theAdapterDateFns*V2adapters for pickers and a small denylist for scheduler's kebab-case views.@mui/internal-bundle-size-checkerto1.0.9-canary.83.We should review the exports of our packages because currently we're leaking private modules.