Skip to content

[code-infra] Validate npm publishing through dry run#23038

Merged
brijeshb42 merged 1 commit into
mui:masterfrom
brijeshb42:code-infra/validate-npm-publishing-dry-run
Jul 3, 2026
Merged

[code-infra] Validate npm publishing through dry run#23038
brijeshb42 merged 1 commit into
mui:masterfrom
brijeshb42:code-infra/validate-npm-publishing-dry-run

Conversation

@brijeshb42

@brijeshb42 brijeshb42 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Ports mui/material-ui#48691 to mui-x.

Validates that npm publishing keeps working over time by running the publish flow in dry-run mode during CI.

Changes

  • CI: Inline the continuous-releases job (previously a call to the ci-base.yml reusable workflow) so it can invoke the ci-publish action directly with npm-dry-run: true. The reusable workflow does not forward the npm-dry-run input to the action, which is why material-ui inlined it as well.
  • Bump @mui/internal-code-infra 0.0.4-canary.660.0.4-canary.74.
  • Remove the deprecated --flat flag from all code-infra build scripts. As of the new code-infra, flat builds are always used and the flag is a no-op scheduled for removal.
  • Fix x-chat-headless declaration output dir (build/esmbuild). It was the only package still emitting types into a nested esm/ folder; the new code-infra always builds flat, so its composite project reference from x-chat broke with TS6305. Aligning outDir with the flat layout fixes the build.

Verification

  • pnpm release:build passes across all packages.
  • code-infra publish --ci --dry-run runs cleanly.

🤖 Generated with Claude Code

@brijeshb42 brijeshb42 added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Jul 2, 2026
@brijeshb42
brijeshb42 force-pushed the code-infra/validate-npm-publishing-dry-run branch from e6c9cdf to c7e31c9 Compare July 2, 2026 12:17
@code-infra-dashboard

code-infra-dashboard Bot commented Jul 2, 2026

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-23038--material-ui-x.netlify.app/
QR code for https://deploy-preview-23038--material-ui-x.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-scheduler 0B(0.00%) 0B(0.00%)
@mui/x-scheduler-premium 0B(0.00%) 0B(0.00%)
@mui/x-chat 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 2,135.23 ms +42.33 ms(+2.0%) | Renders: 63 (+0)

Test Duration Renders
CandlestickChart with big data amount (webgl renderer) 250.88 ms 🔺+60.42 ms(+31.7%) 5 (+0)
HeatmapPremium: 100x100 grid (webgl renderer) 43.61 ms 🔺+8.82 ms(+25.4%) 5 (+0)
RadialBarChart stacked with multiple series 19.86 ms 🔺+3.44 ms(+20.9%) 2 (+0)
LineChart stacked area with multiple series 166.33 ms ▼-48.71 ms(-22.7%) 2 (+0)
Area chart with big data amount (no marks) 21.44 ms ▼-7.18 ms(-25.1%) 2 (+0)

…and 4 more (+17 within noise) — details

Metric alarms

Test Metric Change
CandlestickChart with big data amount (webgl renderer) bench:paint 🔺 +66.41 ms
HeatmapPremium: 100x100 grid (webgl renderer) bench:paint 🔺 +7.73 ms

Check out the code infra dashboard for more information about this PR.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 2, 2026
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@brijeshb42
brijeshb42 force-pushed the code-infra/validate-npm-publishing-dry-run branch from dcea445 to 59548b7 Compare July 2, 2026 13:53
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 2, 2026
@brijeshb42
brijeshb42 requested a review from a team July 2, 2026 13:56
@brijeshb42
brijeshb42 force-pushed the code-infra/validate-npm-publishing-dry-run branch 3 times, most recently from 23b0c77 to c237479 Compare July 3, 2026 04:07
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 3, 2026
@brijeshb42
brijeshb42 force-pushed the code-infra/validate-npm-publishing-dry-run branch from c237479 to 97e552d Compare July 3, 2026 12:19
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jul 3, 2026
Comment thread .github/workflows/ci.yml
uses: mui/mui-public/.github/workflows/ci-base.yml@4e18082e2410a90d523866a414c4e67296b9892c # master
with:
node-version: '22.22.3'
if: ${{ github.repository_owner == 'mui' }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, effectively something we catch on master?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Or in PRs. It'll run on both.

@brijeshb42
brijeshb42 merged commit 7eb9bfa into mui:master Jul 3, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants