[internals] Replace core-js DisposableStack ponyfill with a minimal fallback#23002
Merged
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
sai6855
added
type: enhancement
…allback `@mui/x-internals/disposable` statically imported the full `core-js-pure` disposable-stack and async-disposable-stack ponyfills as the `globalThis.X ?? ...` fallbacks, so the polyfill (plus its core-js internals) was bundled unconditionally even on engines with native support. Replace them with a minimal, spec-compatible built-in implementation covering the methods used across the codebase (use/adopt/defer/move/dispose/disposed and the dispose symbols), still preferring the native class when present. Removes ~11.7KB gzip from the scheduler barrel and benefits every package that builds on x-internals. Verified against the existing disposable unit tests and the scheduler store dispose tests.
Add coverage that exercises the minimal fallback classes (not the native `globalThis.DisposableStack`) by stubbing the global away and re-importing, so the `?? fallback` branch is the one under test. Covers use (incl. LIFO order, null no-op, non-disposable TypeError), adopt, defer, move, idempotent dispose, registration-after-dispose throwing, and SuppressedError aggregation both with and without a native `SuppressedError`, plus the async stack.
sai6855
force-pushed
the
scheduler-core-js
branch
from
June 29, 2026 18:53
613bd81 to
ad4fb0e
Compare
romgrk
reviewed
Jun 29, 2026
romgrk
left a comment
romgrk
left a comment
Contributor
There was a problem hiding this comment.
Good catch, didn't realize it wasn't tree-shaken. LGTM, but we can also remove core-js from the dependencies.
With the disposable stacks no longer importing core-js-pure, x-internals was its only consumer, so drop it from the package dependencies, the workspace catalog, and the build-script allowlist, and refresh the lockfile.
Member
Author
Done, removed from dependencies |
rita-codes
approved these changes
Jun 30, 2026
Member
There was a problem hiding this comment.
Nice cleanup!! Thanks for taking care of this 🙇♀️ the fallback is spec-faithful and actually covers the full surface 🙌
One nit before merge: the suppressed-error fallback message gets minified (registered as code 295) and isn't MUI X:-prefixed, unlike the other two new errors in the file which are /* minify-error-disabled */. Since it's meant to mirror the native SuppressedError default text, I'd mark it /* minify-error-disabled */ and drop the 295 entry, that keeps the native-compatible message in production and matches the other errors here 👀
Thanks!
…fier The fallback message mirrors the native SuppressedError default text, so it should ship verbatim in production rather than be replaced by an error code. Mark the `new Error` `/* minify-error-disabled */` (matching the other fallback errors in the file) and drop the now-unused error code 295.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mui/x-internals/disposablestatically imported the fullcore-js-puredisposable-stack and async-disposable-stack ponyfills as theglobalThis.X ?? ...fallbacks, so the polyfill (plus its core-js internals) was bundled unconditionally even on engines with native support.Replace them with a minimal, spec-compatible built-in implementation covering the methods used across the codebase (use/adopt/defer/move/dispose/disposed and the dispose symbols), still preferring the native class when present. Removes ~11.7KB gzip from the scheduler barrel and 12kb from tree view