[core] Align the eslint configuration with the main repository#23
Merged
Conversation
1 task
dtassone
reviewed
Jun 25, 2020
Member
Author
|
@dtassone Question, do you still want to get the lint command in each package's scripts? |
oliviertassinari
added
PR: needs revision
and removed
on hold
oliviertassinari
force-pushed
the
sync-eslint-with-main-repository
branch
4 times, most recently
from
June 28, 2020 18:08
6dbc9cd to
58cb97a
Compare
oliviertassinari
added
the
internal
dtassone
approved these changes
Jul 1, 2020
| "@types/styled-components": "^5.0.1", | ||
| "@typescript-eslint/eslint-plugin": "^2.19.0", | ||
| "@typescript-eslint/parser": "^2.19.0", | ||
| "babel-eslint": "^10.1.0", |
Contributor
There was a problem hiding this comment.
why do we need all this extra pkgs?
Member
Author
There was a problem hiding this comment.
oliviertassinari
force-pushed
the
sync-eslint-with-main-repository
branch
2 times, most recently
from
July 1, 2020 22:14
3e2a417 to
13d0ad9
Compare
oliviertassinari
force-pushed
the
sync-eslint-with-main-repository
branch
from
July 2, 2020 09:00
e9d0101 to
0273bfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step that will help with alignment with the main repository: #6. The end goal is: one single configuration for all the infrastructure tooling, low entropy, high consistency. I start with eslint because as one of the highest ROI tasks on this matter.
Regarding Lodash, we might want to ignore the prettier update coming from it, until we remove it from the source: #7