[pickers] Fix localized digit crash#22995
Merged
Merged
Conversation
alexfauquette
added
type: bug
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
LukasTy
reviewed
Jun 29, 2026
LukasTy
left a comment
LukasTy
left a comment
Member
There was a problem hiding this comment.
Thank you for taking the time to fix this. 🙏
Here are a couple of suggestions.
Could we apply at least the localizedDigits cleanup?
- (Optional, reuse)
useFieldSectionContentPropsaddsconst localizedDigits = useMemo(() => getLocalizedDigits(adapter), [adapter]), but the identical value is already computed inuseFieldStateand exposed asstateResponse.localizedDigits-- which this hook already destructures. ReusingstateResponse.localizedDigitsdrops the duplicate memo + the extragetLocalizedDigitsimport and keeps a single source of truth. Same adapter and same memo deps, so it is functionally identical and safe. - (Minor, test) The reported crash was luxon
ar-SD; the regression test exercises moment-hijriar-sa. Same root cause (localized digits -> NaN), so it is a valid lock-in, but it does not directly cover the exact reported adapter/locale.
LukasTy
added
needs cherry-pick
Contributor
|
Cherry-pick PRs will be created targeting branches: v8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #20355