[pickers] Use the Hijri day token in AdapterMomentHijri normalDateWithWeekday#22972
Merged
LukasTy merged 1 commit intoJun 26, 2026
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Author
|
@LukasTy @michelengelen Kindly have a review on this pr. Thanks! |
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Merged
1 task
LukasTy
added
type: bug
LukasTy
changed the title
AdapterMomentHijri normalDateWithWeekday
LukasTy
approved these changes
Jun 26, 2026
LukasTy
left a comment
LukasTy
left a comment
Member
There was a problem hiding this comment.
Thank you for the contribution. 🙏
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Hijri adapter's
normalDateWithWeekdayformat, which used the Gregorian day tokenDD.AdapterMomentHijridefinednormalDateWithWeekday: 'DD iMMMM'.DDis the Gregorian day-of-month token (not the HijriiD), so it rendered the Gregorian day, and the format had no weekday despite its name. For 6 Jumada I 1441 (2020-01-01) it produced٠١ جمادى الأولى(Gregorian day01) instead of the Hijri٦.The fix changes it to
'ddd, iD iMMMM'(short weekday, Hijri day, full Hijri month). This restores the weekday the format name and its JSDoc contract require (@example "Sun, Jan 1"), and matches the sibling non-Gregorian Jalali adapters, whosenormalDateWithWeekdayis'EEE, d MMMM'(short weekday, day first, full month).Impact is low because the toolbar only uses
normalDateWithWeekdayfor English locales and the Hijri adapter isar-SA(so it falls back tonormalDate), but the format is public viaadapter.formats.Closes #22964