[virtualizer] Improve the dimensions' initial state#22885
Conversation
arminmeh
added
internal
arminmeh
changed the title
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
| ...dimensionsParams, | ||
| autoHeight, | ||
| minimalContentHeight, | ||
| topContainerHeight, |
There was a problem hiding this comment.
Is this the key change that solves the layout jump in the original issue?
Other changes (positions and currentPageTotalHeight) seem to have no impact on same-row-height use case, right?
There was a problem hiding this comment.
Also, adding needs-cherrypick label so we bring it to v8 too.
There was a problem hiding this comment.
Is this the key change that solves the layout jump in the original issue?
Other changes (positions and currentPageTotalHeight) seem to have no impact on same-row-height use case, right?
Both correct.
Logic is extended to try to precalculate sizes in case you provide getRowHeight callback. It will still miss if it returns auto for some rows, but for numbers it will match the sizes correctly.
cherniavskii
added
needs cherry-pick
|
Cherry-pick PRs will be created targeting branches: v8.x |
Co-authored-by: Andrew Cherniavskii <[email protected]>
2 participants
Make the initial values more accurate