[code-infra] Remove release:build from docs:build script#22852
Conversation
brijeshb42
added
type: regression
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
|
Do we still need this? |
29793c3 to
2b50ac8
Compare
brijeshb42
added
type: bug
2b50ac8 to
128a021
Compare
|
Not needed. Removed. |
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
Ok for me if @mui/grid @mui/charts agree with aligning the docs dev mode with core again.
If it works I'm ok with it 🤷 |
128a021 to
beca37a
Compare
There was a problem hiding this comment.
OK, so we still build the packages from source in the deployment because of pnpm workspace:^ linking, but we don't need to run pnpm release:build – Next.js takes care of bundling the packages instead.
Is this correct?
There was a problem hiding this comment.
Yes. packges are aliased through tsconfig paths which is used to resolve the actual source by turbo/webpack.
This is how it worked before the referenced PR.
beca37a to
1a1e53a
Compare
| enablePrePostScripts: true | ||
|
|
||
| allowBuilds: | ||
| '@mui/x-charts-vendor': true |
There was a problem hiding this comment.
CI doesn't run postinstall without explicit whitelisting.
There was a problem hiding this comment.
Netlify build started to fail: #22832
https://app.netlify.com/projects/material-ui-x/deploys/6a33c853cfe86e0008c1ab6d
12:30:10 PM: Module not found: Can't resolve '@mui/x-charts-vendor/d3-interpolate'
The release:build step was added to docs:build in mui#17214 to build package dist output because source files imported .css files, which required compilation before docs could consume them. Source no longer imports any .css files, so building packages upfront is unnecessary. The step is now a leftover remnant from that PR.
333dfe5 to
d24411e
Compare
4 participants
The release:build step was added to docs:build in #17214 to build package dist output because source files imported .css files, which required compilation before docs could consume them.
Source no longer imports any .css files, so building packages upfront is unnecessary saving around 90sec during docs build. The step is now a leftover remnant from that PR.