Skip to content

[code-infra] Bump vitest packages to 4.1.8 to fix browser-test version skew#22845

Merged
Janpot merged 2 commits into
mui:masterfrom
Janpot:fix/vitest-pin-4.1.8
Jun 17, 2026
Merged

[code-infra] Bump vitest packages to 4.1.8 to fix browser-test version skew#22845
Janpot merged 2 commits into
mui:masterfrom
Janpot:fix/vitest-pin-4.1.8

Conversation

@Janpot

@Janpot Janpot commented Jun 17, 2026

Copy link
Copy Markdown
Member

Problem

The catalog pinned all vitest packages at ^4.1.7. A lockfile bump let vitest core float to 4.1.8 while the @vitest/browser* packages stayed at 4.1.7. vitest warns about this on every browser run:

Loaded [email protected] and @vitest/[email protected].
Running mixed versions is not supported and may lead into bugs.

The skew also intermittently fails browser tests that assert a render-time throw — e.g. x-chat-headlessuseChatActions.test.tsx"throws outside a ChatProvider" — because render-error interception crosses the mismatched core ↔ browser-provider boundary.

Fix

Bump every vitest catalog entry to ^4.1.8 and re-resolve the lockfile so core and the browser provider land on the same version.

Verification

pnpm test:browser --project "x-chat-headless" --run → no mixed-version warning, all 660 tests pass (previously-flaky test green on first attempt).

@code-infra-dashboard

code-infra-dashboard Bot commented Jun 17, 2026

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-22845--material-ui-x.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@LukasTy LukasTy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to be attentive to see if other package bumps don't reintroduce duplicate packages due to stricter version matching.

Technically, a regular package version alignment would suffice, and when renovate starts running again, this should happen anymore. 🤔

The catalog pinned all vitest packages at ^4.1.7, which let a lockfile bump float vitest core to 4.1.8 while @vitest/browser* stayed at 4.1.7. That mixed-version state triggered vitest's "Running mixed versions is not supported" warning and intermittently failed browser tests that assert render-time throws (e.g. x-chat-headless useChatActions). Bump every vitest package to ^4.1.8 and re-resolve so core and the browser provider land on the same version.
@Janpot
Janpot force-pushed the fix/vitest-pin-4.1.8 branch from f9442d7 to e742c6a Compare June 17, 2026 09:04
@Janpot Janpot changed the title [core] Pin vitest packages to 4.1.8 to fix browser-test version skew [core] Bump vitest packages to 4.1.8 to fix browser-test version skew Jun 17, 2026
@Janpot Janpot added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: regression A bug, but worse, it used to behave as expected. labels Jun 17, 2026
@Janpot
Janpot marked this pull request as ready for review June 17, 2026 11:35
@Janpot
Janpot merged commit be0801c into mui:master Jun 17, 2026
23 of 25 checks passed
@Janpot Janpot changed the title [core] Bump vitest packages to 4.1.8 to fix browser-test version skew [code-infra] Bump vitest packages to 4.1.8 to fix browser-test version skew Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants