[test] Wait for GridToolbarCustom rows before screenshot#22844
Merged
Janpot merged 2 commits intoJun 17, 2026
Conversation
Janpot
added
type: regression
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
LukasTy
approved these changes
Jun 17, 2026
Janpot
marked this pull request as ready for review
June 17, 2026 11:36
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docs-data-grid-components-toolbar/GridToolbarCustomregression screenshot intermittently captures the grid's loading state on master. The demo loads rows asynchronously viauseDemoData, which the screenshot harness'saria-busygate only tracks for fonts — not async demo data — so the capture races the skeleton overlay.Add a per-route
waitForSelectorrule that waits for a real (non-skeleton) data row before screenshotting. Skeleton overlay rows carry both.MuiDataGrid-rowand.MuiDataGrid-rowSkeleton, so the selector excludes the latter.