[code-infra] Port codebase to use tsgo#22826
Conversation
Deploy previewhttps://deploy-preview-22826--material-ui-x.netlify.app/Bundle size
PerformanceTotal duration: 1,473.40 ms -85.89 ms(-5.5%) | Renders: 63 (+0)
…and 1 more (+20 within noise) — details Check out the code infra dashboard for more information about this PR. |
| minimumReleaseAgeExclude: | ||
| - '@mui/*' | ||
| - '@base-ui/*' | ||
| - '@typescript/native-preview*' |
There was a problem hiding this comment.
Temporary change.
70baa71 to
cee441c
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
a429301 to
0b8b4be
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/extensions.json |
There was a problem hiding this comment.
This is probably not a good idea. Just tell ppl to install/enable the extension/settings for the time being, else it will conflict with everyone's local settings
There was a problem hiding this comment.
But then how do we share common settings for the repo. Currently, we are enabling this and it should automatically get enabled for everyone when they pull. Then after few months, we'll need to revisit this again to cleanup
Informing on Slack seems tedious since there's also the requirement of installing the extension.
For users, workspace settings is there (as well as user settings) where they can customize. We are doing the same in base-ui and core.
There was a problem hiding this comment.
🤷 we can go with it, it will just break stuff for everyone that uses vscode.
It is vscode's fault it doesn't have a proper way of handling it instead of just creating a custom workspace around a single project 🫠
There was a problem hiding this comment.
The settings can still be moved to user settings instead of the repo settings. Right ?
Janpot
left a comment
There was a problem hiding this comment.
lgtm, if it has the blessing of X for the source changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
It'd be great to get a +1 here since this is the only repo not migrated yet. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
LukasTy
left a comment
There was a problem hiding this comment.
A few risky configs, but looks good overall. 👍
Let's ship those speed gains. 🚀
Ports the codebase to use
tsgofor type checking.CI typecheck speedup
Measured on the
test_typesCircleCI job, step "Tests TypeScript definitions":Roughly 3.5× faster typechecks on CI (up to ~5× vs. slower master runs).
CI credit cost
This PR bumps
test_typestoxlarge.gen2(48 credits/min); master runs onlarge.gen2(24 credits/min). CircleCI bills per-second on whole-job wall-clock.Faster end-to-end (~2.5×) and still ~19% cheaper per run despite the larger box.
Verified via emitted .d.ts diff (master vs branch), both tsc and tsgo — outputs identical to each other. None are breaking. None require user action.
Only 2 changes alter the shipped .d.ts at all, both in internal surfaces and both type-compatible.