[charts] Support unknownColor in color scale#22813
Merged
Merged
Conversation
alexfauquette
added
type: enhancement
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
JCQuintas
approved these changes
Jun 16, 2026
Comment on lines
+114
to
+115
| By default shapes with unknown values are ignored. | ||
| Specify the `unknownColor` property in the `colorMap` to render them. |
Member
There was a problem hiding this comment.
This behaviour is specific of the map right?
Member
Author
There was a problem hiding this comment.
Yes, I added test to be sure I do not mess up with other charts
For other charts the beahvior is
- if
unknownColoris defined, use it - if it's not defined, use the series color
Comment on lines
+60
to
+66
| <FormControlLabel | ||
| checked={unknownColor} | ||
| control={ | ||
| <Checkbox onChange={(event) => setUnknownColor(event.target.checked)} /> | ||
| } | ||
| label="Use unknown color" | ||
| labelPlacement="end" |
Member
There was a problem hiding this comment.
Would it be better for this demo to not have the background? 🤔
Member
Author
There was a problem hiding this comment.
I will add an info box to inform user about the impact bout the tooltip and add an option in the demos actions to play with it
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support for
unknownColorin continuouse scales.For all charts the behavior shoul dnot be impacted. If
unownColoris not provided the scale will returnnulland so we still fall back to the series color.For the mapShapes, the behavior differs. The
getColorreturnsnulland theShapePlotdoes not render the shape