[scheduler-premium] Remove non-functional onPreferencesChange prop from EventTimelinePremium#22777
Merged
Conversation
…TimelinePremium Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
rita-codes
added
plan: Premium
rita-codes
changed the title
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
…eferenceschange-prop-from-eventtimelinepremium
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
rita-codes
changed the title
onPreferencesChange prop from EventTimelinePremium
…eferenceschange-prop-from-eventtimelinepremium
rita-codes
enabled auto-merge (squash)
June 12, 2026 09:50
…eferenceschange-prop-from-eventtimelinepremium
The test hardcoded a 1500px host height assuming a fixed header height. Without the responsive typography container ancestor, the header renders at its largest tier (~461px), leaving the body shorter than its 1104px content, so it overflowed and `data-has-scroll` was set on the first assertion. Size the host to its content instead so the body never overflows initially, independent of the header height. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
rita-codes
disabled auto-merge
June 12, 2026 12:47
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
…from `EventTimelinePremium` (mui#22777) Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22739
Summary
EventTimelinePremiumexposed a publiconPreferencesChangeprop that was never fired: the Timeline store has nosetPreferencesmethod and no preferences-editing UI, so the callback never ran. It was a dead public prop and removing it after the stable release would have been a breaking change.It also had an inconsistent signature (
event: React.UIEvent | Eventinstead of theeventDetails: SchedulerChangeEventDetailsused everywhere else, including the Timeline's ownonPresetChange).Changes
Removed
onPreferencesChangefrom the Timeline's public surface:EventTimelinePremiumStore.types.ts(EventTimelinePremiumParameters)useExtractEventTimelinePremiumParameters.ts(destructuring, memo object, and deps array)EventTimelinePremium.tsxRegenerated the API docs (
pnpm proptypes+pnpm docs:api).Kept intentionally
preferences/defaultPreferencesstay —ampmis read in the grid header to format times (12h/24h) and they support controlled usage.onPreferencesChangeon the standalone views andEventCalendarPremiumis functional and untouched.If preferences editing is added to the Timeline later,
onPreferencesChangeshould be reintroduced with the standard(preferences, eventDetails: SchedulerChangeEventDetails) => voidsignature, wired through asetPreferencesmethod mirroringEventCalendarStore.