[scheduler] Remove dead CSS variable writes in EventTimelinePremiumContent#22720
Merged
brijeshb42 merged 5 commits intoJun 10, 2026
Merged
Conversation
The --events-scroll-left CSS variable is no longer written anywhere on master (the setter and the left: consumer were removed earlier), so the two `translateX(calc(-1 * var(--events-scroll-left, 0) * 1px))` rules in EventTimelinePremiumContent always resolved to translateX(0). Drop them. Confirmed as a leftover by @romgrk in mui#22389. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
rita-codes
added
type: enhancement
rita-codes
requested review from
noraleonte and
romgrk
and removed request for
noraleonte
June 9, 2026 16:03
--has-scroll-y was written on the content root but never read anywhere (only --has-scroll-x is consumed, for the vertical size calc). Drop the dead write; the hasScrollY JS value is still used for conditional rendering of the vertical scrollbar. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
rita-codes
changed the title
--events-scroll-left transforms
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
romgrk
approved these changes
Jun 9, 2026
rita-codes
enabled auto-merge (squash)
June 10, 2026 09:06
noraleonte
approved these changes
Jun 10, 2026
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
…ntent (mui#22720) Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two dead CSS custom-property writes in
EventTimelinePremiumContent, both no longer read anywhere onmaster:--events-scroll-left— the setter and theleft:consumer were removed in earlier work. The only remaining references were twotransform: translateX(calc(-1 * var(--events-scroll-left, 0) * 1px))rules (EventsHeaderCellContentandEventsCell); with nothing setting the variable they always resolved totranslateX(0). Confirmed as a leftover by @romgrk in [scheduler][timeline] Scrolling issues #22389 (comment).--has-scroll-y— written on the content root but never consumed (only--has-scroll-xis read, for the vertical size calc). ThehasScrollYJS value is kept; it's still used for conditional rendering of the vertical scrollbar.No behavior change — both writes were no-ops.
Context: #22389 (point 2).