[charts] Add FocusedBar component to BarScatterComposition demo#22704
Merged
Conversation
sai6855
added
type: bug
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the charts docs demo for the “bar + scatter composition” example so that focused bars get a visible focus outline during keyboard navigation, aligning the demo behavior with the documented composition markup.
Changes:
- Import
FocusedBarfrom@mui/x-charts/BarChartin the BarScatterComposition demo. - Render
<FocusedBar />in the composed chart surface so focused bars are visually highlighted.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/data/charts/bars/BarScatterCompostion.tsx | Adds FocusedBar to the TS demo composition so focused bars show a focus outline. |
| docs/data/charts/bars/BarScatterCompostion.js | Adds FocusedBar to the JS demo composition so focused bars show a focus outline. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
104
to
106
| <ChartsXAxis axisId="bar" /> | ||
| <FocusedBar /> | ||
| <ChartsYAxis /> |
Comment on lines
3
to
4
| import { BarPlot, FocusedBar } from '@mui/x-charts/BarChart'; | ||
| import { ScatterPlot } from '@mui/x-charts/ScatterChart'; |
Comment on lines
102
to
104
| <ChartsXAxis axisId="bar" /> | ||
| <FocusedBar /> | ||
| <ChartsYAxis /> |
Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: sai chand <[email protected]>
JCQuintas
approved these changes
Jun 9, 2026
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
…22704) Signed-off-by: sai chand <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19708
FocusedBaris present in markup but missing in actual demo. This PR addsFocusedBarin demo, to highlight focused barPreview https://deploy-preview-22704--material-ui-x.netlify.app/x/react-charts/bars/#composition