Skip to content

[charts-pro] Add missing focuse highlight#22689

Merged
alexfauquette merged 4 commits into
mui:masterfrom
alexfauquette:add-focused-bar
Jun 9, 2026
Merged

[charts-pro] Add missing focuse highlight#22689
alexfauquette merged 4 commits into
mui:masterfrom
alexfauquette:add-focused-bar

Conversation

@alexfauquette

Copy link
Copy Markdown
Member

Noticed while reviewing the sub-sampling PR that some pro charts don't have focus highlight component

@alexfauquette
alexfauquette requested a review from JCQuintas as a code owner June 5, 2026 07:44
@alexfauquette alexfauquette added type: bug It doesn't behave as expected. plan: Pro Impact at least one Pro user. scope: charts Changes related to the charts. labels Jun 5, 2026
@code-infra-dashboard

code-infra-dashboard Bot commented Jun 5, 2026

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-22689--material-ui-x.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+45B(+0.01%) 🔺+25B(+0.02%)
@mui/x-charts-premium 🔺+54B(+0.01%) 🔺+39B(+0.02%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)
@mui/x-license 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

Total duration: 1,886.96 ms -163.48 ms(-8.0%) | Renders: 67 (+0) | Paint: 2,735.13 ms -316.33 ms(-10.4%)

Test Duration Renders
BarChartPro with big data amount 36.25 ms ▼-14.48 ms(-28.5%) 3 (+0)
ScatterChart with big data amount 24.85 ms ▼-7.99 ms(-24.3%) 2 (+0)
RadialLineChart with big data amount 14.72 ms ▼-4.71 ms(-24.3%) 2 (+0)
PieChart with big data amount 8.83 ms ▼-2.95 ms(-25.1%) 2 (+0)
RadarChart with many axes and multiple series 7.58 ms ▼-2.25 ms(-22.9%) 2 (+0)

21 tests within noise — details


Check out the code infra dashboard for more information about this PR.

@alexfauquette
alexfauquette enabled auto-merge (squash) June 5, 2026 08:06
@JCQuintas

Copy link
Copy Markdown
Member

Shouldn't this be added to PieChartPro and RadarChartPro too?

@alexfauquette
alexfauquette disabled auto-merge June 5, 2026 14:44
@alexfauquette
alexfauquette merged commit e24ec13 into mui:master Jun 9, 2026
21 checks passed
mbrookes pushed a commit to mbrookes/mui-x that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plan: Pro Impact at least one Pro user. scope: charts Changes related to the charts. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants