[charts-premium] Support maps tooltip positioned on items#22648
Merged
Conversation
alexfauquette
added
plan: Premium
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
alexfauquette
changed the title
github-actions
Bot
removed
the
PR: out-of-date
alexfauquette
changed the title
alexfauquette
marked this pull request as ready for review
June 9, 2026 14:39
Deploy previewBundle size
PerformanceTotal duration: 2,230.52 ms +44.36 ms(+2.0%) | Renders: 67 (+0)
24 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
JCQuintas
reviewed
Jun 10, 2026
Comment on lines
+2
to
+23
| import { | ||
| geoAlbers, | ||
| geoAlbersUsa, | ||
| geoAzimuthalEqualArea, | ||
| geoAzimuthalEquidistant, | ||
| geoConicConformal, | ||
| geoConicEqualArea, | ||
| geoConicEquidistant, | ||
| geoEqualEarth, | ||
| geoEquirectangular, | ||
| geoGnomonic, | ||
| geoMercator, | ||
| geoNaturalEarth1, | ||
| geoOrthographic, | ||
| geoStereographic, | ||
| geoTransverseMercator, | ||
| geoPath, | ||
| type ExtendedFeatureCollection, | ||
| type GeoProjection, | ||
| type GeoPath, | ||
| type GeoConicProjection, | ||
| } from '@mui/x-charts-vendor/d3-geo'; |
Member
There was a problem hiding this comment.
This adds all of these projections to the community package for not a lot of value it seems 🤔
This kinda of follows what we do for axis+zoom, but that is a bit lighter I think 😆
Maybe we should have tooltipItemPositionGetter access state? So we can make it use selectors? Not sure it would work
Member
Author
There was a problem hiding this comment.
With just an object ref copy the additional selector should not have too much of an impact 👍
JCQuintas
approved these changes
Jun 10, 2026
mbrookes
pushed a commit
to mbrookes/mui-x
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the tooltip anchor to the corresponding feature bounding box when it exist
Because the tooltip position is in MIT package, I had to move selectors and types to the community like we do for zoom