Skip to content

[code-infra] Allow user to select target branch if it exists for current major#20992

Merged
JCQuintas merged 4 commits intomui:masterfrom
JCQuintas:fix-release-pr-script
Jan 21, 2026
Merged

[code-infra] Allow user to select target branch if it exists for current major#20992
JCQuintas merged 4 commits intomui:masterfrom
JCQuintas:fix-release-pr-script

Conversation

@JCQuintas
Copy link
Copy Markdown
Member

No description provided.

@JCQuintas JCQuintas requested a review from a team January 21, 2026 13:42
@JCQuintas JCQuintas self-assigned this Jan 21, 2026
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. needs cherry-pick The PR should be cherry-picked to master after merge. v8.x scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Jan 21, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Jan 21, 2026

Deploy preview: https://deploy-preview-20992--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 23d0c06

@Janpot Janpot requested a review from brijeshb42 January 21, 2026 16:17
Copy link
Copy Markdown
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Suggestion to make it slightly more defensive: create a separate branchExists(branchName) function to avoid having the confirm call poison the catch clause. Will probably never fail in practice though.

@brijeshb42 to sign off on it.

@JCQuintas JCQuintas merged commit c7b3084 into mui:master Jan 21, 2026
22 checks passed
@JCQuintas JCQuintas deleted the fix-release-pr-script branch January 21, 2026 16:33
@github-actions
Copy link
Copy Markdown
Contributor

Cherry-pick PRs will be created targeting branches: v8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. v8.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants