[code-infra] Allow user to select target branch if it exists for current major#20992
Merged
JCQuintas merged 4 commits intomui:masterfrom Jan 21, 2026
Merged
[code-infra] Allow user to select target branch if it exists for current major#20992JCQuintas merged 4 commits intomui:masterfrom
JCQuintas merged 4 commits intomui:masterfrom
Conversation
|
Deploy preview: https://deploy-preview-20992--material-ui-x.netlify.app/ Bundle size report
|
Janpot
reviewed
Jan 21, 2026
Janpot
reviewed
Jan 21, 2026
Janpot
reviewed
Jan 21, 2026
Janpot
reviewed
Jan 21, 2026
Janpot
reviewed
Jan 21, 2026
Member
There was a problem hiding this comment.
Looks good to me. Suggestion to make it slightly more defensive: create a separate branchExists(branchName) function to avoid having the confirm call poison the catch clause. Will probably never fail in practice though.
@brijeshb42 to sign off on it.
brijeshb42
approved these changes
Jan 21, 2026
Contributor
|
Cherry-pick PRs will be created targeting branches: v8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.