[pickers] Mark active range position field section with underline#16938
Merged
Conversation
LukasTy
added
plan: Pro
3 tasks
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
removed
the
PR: out-of-date
noraleonte
reviewed
Apr 9, 2025
noraleonte
left a comment
noraleonte
left a comment
Contributor
There was a problem hiding this comment.
Awesome work! 🎉 💙
Leaving some suggestions/ a potential fix for the positioning and slightly off widths of the activeBar
Before:
After:
bernardobelchior
pushed a commit
to bernardobelchior/mui-x
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #9431.
Adds active range section underlining in the field when the Picker is open.
Warning
Chrome seems buggy with
transparenttext decoration and still renders it in a default color. 🙈Screen.Recording.2025-03-12.at.14.59.04.mov
Exhausted explored options
text-decoration: underlinevariantsnone->underline) that works on Chrome (changing the color from transparent)border-bottomvariantsCurrent solution
Element or pseudo-element that would be absolutely positioned within relate
TextField.