[TimeRangePicker] Shift popper between start and end input on multi input field#16920
Merged
Conversation
LukasTy
added
plan: Pro
3 tasks
github-actions
Bot
added
the
PR: out-of-date
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
removed
the
PR: out-of-date
LukasTy
commented
Mar 12, 2025
| } | ||
|
|
||
| export interface PickerPrivateContextValue { | ||
| /* |
Member
Author
There was a problem hiding this comment.
I just moved the attributes around to sort them alphabetically. 🙈
flaviendelangle
left a comment
flaviendelangle
left a comment
Member
There was a problem hiding this comment.
I would like a behavior double check of @noraleonte
But for me it make a lot of sense to enable it only on our MUI multi input field and only for the time range picker.
flaviendelangle
approved these changes
Mar 12, 2025
noraleonte
approved these changes
Mar 14, 2025
noraleonte
left a comment
noraleonte
left a comment
Contributor
There was a problem hiding this comment.
The behavior makes a lot of sense to me 👌 Thanks for the effort on this one 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #9431.
Adds
triggerRefshifting between start and end fields when using Picker with aMultiInputTimeRangeField.Screen.Recording.2025-03-11.at.17.59.56.mov