Conversation
* v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace
* implemented server pagination * rename pagination options, doc, prettier * fix lint * Apply suggestions from code review Co-authored-by: Olivier Tassinari <[email protected]> * change casing value in featureMode and remove apiref check * added missing dep in useEffect * fix broken suggestion code * fix doc comments * Apply suggestions from code review Co-authored-by: Olivier Tassinari <[email protected]> * Fix FeatureMode enum and remove useCallback in demo * fix import order * added namespace to function call to remove import * remove useCallback and add react. to mdx code * add concurrency in server pagination demo * fix feature mode export Co-authored-by: Olivier Tassinari <[email protected]>
* rename events and added onHover event * rename events and added onHover event * fix onPageChange rename and merge * Js doc improvements Co-authored-by: Olivier Tassinari <[email protected]> * added hover stories * small fix and cleanup * revert rename, back to onRowSelected * refactor hover and click handlers * refactor cellParams * prettier Co-authored-by: Olivier Tassinari <[email protected]>
* override default logLevel to warn * rerun CI Co-authored-by: Olivier Tassinari <[email protected]>
* v0.1.51 * fix demo app build * v0.1.52 * v0.1.53 * v0.1.54 * v0.1.55 * v0.1.56 * v0.1.57 * v0.1.58 * v0.1.59 * add missing export * v0.1.60 * v0.1.61 * hot fix for tsconfig conf * fix mistypes on the package.json * fix empty space with prettier * v0.1.62 * fix lerna.json whitespace * v0.1.63 * v0.1.64 * prettier lerna.json due to lerna
* fix cellClassRule type, fix keyboard timeout, small refactoring * prettier fix * add cancel RAF for focus if new event coming
|
Merging master in release. I will publish and deploy once merged |
|
Have you considered to release from master directly? Have you considered to push force master to the release branch? |
I don't want to release from master as we can break things easily on this branch. And that way we can control a bit more when we release. |
|
I don't know what's the best approach around handling release, some of the things I think are important:
A few tools we could leverage:
I know that @eps1lon started to work on release automation, but I think that it was put on hold. I recall we had a debate around either we should have one tag/commit per package release or a single tag that bundles all the released packages. |
Because I don't want to have discussions about the version every time. I would be nice if we could recognize SemVer but we only mention it in name. And every time we actual do a release we have to go over what we personally consider "minor" or "major" or if it's "likely to break". I repeat what I said before: Do what works best for you on this repository. There isn't a single right way to do things that should be repeated just in pursuit of "consistency". |
I definitely agree with this sentence :) And I also believe that we need to improve our release process for X. The process is currently manual, but bear with us, we are still in early-stage with the project. |
* added keyboard doc * Apply suggestions from code review Co-authored-by: Olivier Tassinari <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
* fix selection issue * fix selection issue test
@eps1lon From what I understand, we could simplify the discussion by using https://www.conventionalcommits.org/. It would then come down to what's the correct commit message for each pull request.
I think that the pursuit of "consistency" is fruitless. It can only be the consequence of an objective or a tool to reach an objective. It should never the objective itself. For instance, consistency of the pattern of I share some of what I think the strategy should be in #115 (comment) (the what and why). The key elements for treating the two repositories as a single entity:
I also think that once we get more than 10 people in the team, it starts to make sense to allow more explorations and short/medium-term divergences, as the potential ROI increases. |
No description provided.